Re: [coreboot] [PATCH] __FUNCTION__ -> __func__

[Myles Watson]

On Thu, Feb 12, 2009 at 10:00 AM, ron minnich  wrote:
> On Thu, Feb 12, 2009 at 5:48 AM, Carl-Daniel Hailfinger
>  wrote:
> > Hm. Right now, we have a mix of styles in v2.
> > __func__ is used 43 times
> > __FUNCTION__ is used 153 times.
> > I'd rather leave that cleanup for a separate patch.
>
> it's a sign of the age of the project. When we started, __FUNCTION__
> was common usage.
>
> We can clean it up later, and cleanup would be good.

Patches attached.

Signed-off-by: Myles Watson

Thanks,
Myles

[PATCH] __FUNCTION__ -> __func__

[Carl-Daniel Hailfinger]

On 12.02.2009 18:40, Myles Watson wrote:
> On Thu, Feb 12, 2009 at 10:00 AM, ron minnich  wrote:
> > On Thu, Feb 12, 2009 at 5:48 AM, Carl-Daniel Hailfinger
> >  wrote:
> > > Hm. Right now, we have a mix of styles in v2.
> > > __func__ is used 43 times
> > > __FUNCTION__ is used 153 times.
> > > I'd rather leave that cleanup for a separate patch.
> >
> > it's a sign of the age of the project. When we started, __FUNCTION__
> > was common usage.
> >
> > We can clean it up later, and cleanup would be good.
>
> Patches attached.
>
> Signed-off-by: Myles Watson

If they are abuild-tested, they are
Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[PATCH] __FUNCTION__ -> __func__

[Myles Watson]

On Thu, Feb 12, 2009 at 1:24 PM, Carl-Daniel Hailfinger
 wrote:
> On 12.02.2009 18:40, Myles Watson wrote:
> > On Thu, Feb 12, 2009 at 10:00 AM, ron minnich  wrote:
> > > On Thu, Feb 12, 2009 at 5:48 AM, Carl-Daniel Hailfinger
> > >  wrote:
> > > > Hm. Right now, we have a mix of styles in v2.
> > > > __func__ is used 43 times
> > > > __FUNCTION__ is used 153 times.
> > > > I'd rather leave that cleanup for a separate patch.
> > >
> > > it's a sign of the age of the project. When we started, __FUNCTION__
> > > was common usage.
> > >
> > > We can clean it up later, and cleanup would be good.
> >
> > Patches attached.
> >
> > Signed-off-by: Myles Watson
>
> If they are abuild-tested, they are
> Acked-by: Carl-Daniel Hailfinger

Abuild tested.
v3: 1131
v2: 3943

Thanks,
Myles