Re: [LinuxBIOS] [linuxbios-checkins] r2301 - trunk/LinuxBIOSv2/src/cpu/amd/model_gx2

[Stefan Reinauer]

* [e-mail]  [060506 04:54]:
> Modified:
>    trunk/LinuxBIOSv2/src/cpu/amd/model_gx2/vsmsetup.c
> Log:
> Use a real variable to configure rom base for vsa ...
> Modified: trunk/LinuxBIOSv2/src/cpu/amd/model_gx2/vsmsetup.c
>
> --- trunk/LinuxBIOSv2/src/cpu/amd/model_gx2/vsmsetup.c	2006-05-06 02:35:08 UTC (rev 2300)
> +++ trunk/LinuxBIOSv2/src/cpu/amd/model_gx2/vsmsetup.c	2006-05-06 02:54:45 UTC (rev 2301)
> //rom = 0xfffc0000;
> /* the VSA starts at the base of rom - 128k */
> rom = ((unsigned long) 0) - (ROM_SIZE  + 128*1024);

dumb question:
Since this is in the CPU code and not motherboard specific, should this
be a config variable, in case someone uses different VSMs? Or are they
always 128k?

Stefan

[LinuxBIOS] [linuxbios-checkins] r2301 - trunk/LinuxBIOSv2/src/cpu/amd/model_gx2

[Ronald G Minnich]

Stefan Reinauer wrote:
> [e-mail]  [060506 04:54]:
> > Modified:
> >   trunk/LinuxBIOSv2/src/cpu/amd/model_gx2/vsmsetup.c
> > Log:
> > Use a real variable to configure rom base for vsa ...
> > Modified: trunk/LinuxBIOSv2/src/cpu/amd/model_gx2/vsmsetup.c
> >
> > --- trunk/LinuxBIOSv2/src/cpu/amd/model_gx2/vsmsetup.c	2006-05-06 02:35:08 UTC (rev 2300)
> > +++ trunk/LinuxBIOSv2/src/cpu/amd/model_gx2/vsmsetup.c	2006-05-06 02:54:45 UTC (rev 2301)
> > //rom = 0xfffc0000;
> > /* the VSA starts at the base of rom - 128k */
> > rom = ((unsigned long) 0) - (ROM_SIZE  + 128*1024);
>
> dumb question:
> Since this is in the CPU code and not motherboard specific, should this
> be a config variable, in case someone uses different VSMs? Or are they
> always 128k?
>
> Stefan

it's a good question. What I really want to do is kill VSA in the 
linuxbios world. Until I know for sure, let's leave this hack in.

Actually, the variable should be set at buildrom time, but we can't 
accomodate that sort of thing yet.

ron