this at least gets through with a countable number of errors.
Final fixes tomorrow.
ron
On 02.08.2008 23:20, ron minnich wrote:
this at least gets through with a countable number of errors.
Final fixes tomorrow.
Get it to at least mostly compile
Somehow there were two copies of the file in the file -- svn weirdness?
Signed-off-by: Ronald G. Minnich rminnich@gmail.com
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Regards, Carl-Daniel
On Sat, Aug 02, 2008 at 02:20:19PM -0700, ron minnich wrote:
@@ -871,12 +871,10 @@ }
/* Report the amount of memory. */
- print_spew("RAM: 0x");
- print_spew_hex32(tom_k);
- print_spew(" KB\r\n");
- printk(BIOS_SPEW, "RAM: 0x%x DB\n", tom_k);
DB -> KB
Also, we partially use \n and partially \r\n in printk in v3, is there some reason for that? Shall we move everything to \n only?
Uwe.
On 03.08.2008 18:56, Uwe Hermann wrote:
On Sat, Aug 02, 2008 at 02:20:19PM -0700, ron minnich wrote:
@@ -871,12 +871,10 @@ }
/* Report the amount of memory. */
- print_spew("RAM: 0x");
- print_spew_hex32(tom_k);
- print_spew(" KB\r\n");
- printk(BIOS_SPEW, "RAM: 0x%x DB\n", tom_k);
DB -> KB
Also, we partially use \n and partially \r\n in printk in v3, is there some reason for that? Shall we move everything to \n only?
The \r\n is a a legacy from v2. The future is \n only.
Regards, Carl-Daniel
On Sun, Aug 3, 2008 at 9:56 AM, Uwe Hermann uwe@hermann-uwe.de wrote:
On Sat, Aug 02, 2008 at 02:20:19PM -0700, ron minnich wrote:
@@ -871,12 +871,10 @@ }
/* Report the amount of memory. */
print_spew("RAM: 0x");print_spew_hex32(tom_k);print_spew(" KB\r\n");
printk(BIOS_SPEW, "RAM: 0x%x DB\n", tom_k);DB -> KB
Also, we partially use \n and partially \r\n in printk in v3, is there some reason for that? Shall we move everything to \n only?
Good catch, I fixed these as well.
Committed revision 715.
ron
-
Carl-Daniel Hailfinger -
ron minnich -
Uwe Hermann