New patch to review for coreboot: 5cacfa7 Rename fam14 pci northbridge ops functions.

[Marc Jones]

Marc Jones ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2166

-gerrit

commit 5cacfa7fff542050d5b328bde89bfe9750bbddee
Author: Marc Jones 
Date:   Wed Jan 16 17:02:20 2013 -0700

Rename fam14 pci northbridge ops functions.

Clarify the northbridge ops function names.

Change-Id: If7d89de761c1e22f9ae39d36f5cf334cc2910e1d
    Signed-off-by: Marc Jones 
---
 src/northbridge/amd/agesa/family14/northbridge.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c
index 5e8d89b..0bbf10c 100644
--- a/src/northbridge/amd/agesa/family14/northbridge.c
+++ b/src/northbridge/amd/agesa/family14/northbridge.c
@@ -330,12 +330,12 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void)
 }
 #endif

-static void read_resources(device_t dev)
+static void nb_read_resources(device_t dev)
 {
    u32 nodeid;
    struct bus *link;

-	printk(BIOS_DEBUG, "\nFam14h - read_resources.\n");
+	printk(BIOS_DEBUG, "\nFam14h - nb_read_resources.\n");

nodeid = amdfam14_nodeid(dev);
    for (link = dev->link_list; link; link = link->next) {
@@ -429,13 +429,13 @@ static void create_vga_resource(device_t dev, unsigned nodeid)
    set_vga_enable_reg(nodeid, link->link_num);
 }

-static void set_resources(device_t dev)
+static void nb_set_resources(device_t dev)
 {
    unsigned nodeid;
    struct bus *bus;
    struct resource *res;

-	printk(BIOS_DEBUG, "\nFam14h - set_resources.\n");
+	printk(BIOS_DEBUG, "\nFam14h - nb_set_resources.\n");

/* Find the nodeid */
    nodeid = amdfam14_nodeid(dev);
@@ -855,8 +855,8 @@ static void cpu_bus_init(device_t dev)
 /* North Bridge Structures */

static struct device_operations northbridge_operations = {
-	.read_resources = read_resources,
-	.set_resources = set_resources,
+	.read_resources = nb_read_resources,
+	.set_resources = nb_set_resources,
    .enable_resources = pci_dev_enable_resources,
    .init = northbridge_init,
    .enable = 0,.ops_pci = 0,

New patch to review for coreboot: 5cacfa7 Rename fam14 pci northbridge ops functions.

[Peter Stuge]

Marc Jones wrote:
> +++ b/src/northbridge/amd/agesa/family14/northbridge.c

..
> printk(BIOS_DEBUG, "\nFam14h - read_resources.\n");
> printk(BIOS_DEBUG, "\nFam14h - nb_read_resources.\n");

Please use __func__ thanks.

//Peter

New patch to review for coreboot: 5cacfa7 Rename fam14 pci northbridge ops functions.

[Marc Jones]

On Thu, Jan 17, 2013 at 12:01 PM, Peter Stuge  wrote:
> Marc Jones wrote:
> > +++ b/src/northbridge/amd/agesa/family14/northbridge.c
>
> ..
> > printk(BIOS_DEBUG, "\nFam14h - read_resources.\n");
> > printk(BIOS_DEBUG, "\nFam14h - nb_read_resources.\n");
>
> Please use __func__ thanks.

That is a followup patch to fix the entire file.
> //Peter