the following patch was just integrated into master: commit fa91819e898b6df59fbff44c0f4dfccf2fee6e48 Author: Kimarie Hoot kimarie.hoot@se-eng.com Date: Thu Mar 7 16:42:09 2013 -0700
AMD Fam15: Add SPD read functions to wrapper code
Change: This is the initial step for moving the AMD F15 & HUDSON1,2,3 SPD-read callout out of the mainboard directories and into the wrapper. The next step is to update the platforms to use this routine in BiosCallouts.c and to delete the code from the mainboard directories. The DIMM addresses should be moved into devicetree.cb. If there are significant differences or reasons that the mainboard needs to override this code, it's perfectly reasonable to keep using the version in the mainboard, but this allows us to remove duplicated code and simplify the mainboard directories.
Notes: This started by duplicating what was in Dinar, and was changed to use the devicetree.cb structures. Significant cleanup and magic number reduction was done as well.
It is intended that this file will not be included in ramstage as the DIMM init is all done in romstage.
This is similar to what was done for Parmer/Thatcher in commit 7fb692bd - http://review.coreboot.org/#/c/2190/ Fam15tn: Move SPD read from mainboards into wrapper
Yes, it would make sense to split this into two separate files and move the SMBus initialization and access into the southbridge wrapper. Maybe that can come next.
Change-Id: I4e00ada288e1486cf30684403505e475f9093ec2 Signed-off-by: Kimarie Hoot kimarie.hoot@se-eng.com Reviewed-on: http://review.coreboot.org/2777 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) Reviewed-by: Marc Jones marc.jones@se-eng.com
Build-Tested: build bot (Jenkins) at Mon Mar 18 23:05:21 2013, giving +1 Reviewed-By: Marc Jones marc.jones@se-eng.com at Tue Mar 19 17:08:10 2013, giving +2 See http://review.coreboot.org/2777 for details.
-gerrit