[LinuxBIOS] buildrom problems (serengeti cheetah, s2891)

[Myles Watson]

I checked out the latest buildrom and tried to build L-A-B for two targets,
Serengeti cheetah and Tyan s2891.

It fails to build the kernel because it passes KERNEL_CC=gcc -m32 to make,
and make interprets the -m32 as an option to make.

I'm assuming that there's something wrong with my environment, but I'm not
sure how to fix it.

I'm using Fedora Core 4 and gcc 4

Any suggestions?

Myles

[Jordan Crouse]

On 24/10/07 14:11 -0600, Myles Watson wrote:
> I checked out the latest buildrom and tried to build L-A-B for two targets,
> Serengeti cheetah and Tyan s2891.
>
> It fails to build the kernel because it passes KERNEL_CC=gcc -m32 to make,
> and make interprets the -m32 as an option to make.
> I'm assuming that there's something wrong with my environment, but I'm not
> sure how to fix it.

Its not you, its me.. :)  I just recently (this morning) changed buildrom
so that it passed about the 32 bit flags by default, to better enable
building on a 64 bit host.

On its face, this is a bug from way back - we should be
encapsulating all usages of $(CC), $(LD), etc in quotes.  But now I'm
wondering if we should bother passing the flags in to the kernel at all, since
it obviously knows how to do the right thing.

Let me think about it for a few minutes and get a patch up.

Jordan

[Jordan Crouse]

On 24/10/07 14:11 -0600, Myles Watson wrote:
> I checked out the latest buildrom and tried to build L-A-B for two targets,
> Serengeti cheetah and Tyan s2891.
>
> It fails to build the kernel because it passes KERNEL_CC=gcc -m32 to make,
> and make interprets the -m32 as an option to make.
>
> I'm assuming that there's something wrong with my environment, but I'm not
> sure how to fix it.
>
> I'm using Fedora Core 4 and gcc 4
>
> Any suggestions?

Try this patch to buildrom - it should make everybody happy.

Jordan

[Ward Vandewege]

On Wed, Oct 24, 2007 at 02:38:42PM -0600, Jordan Crouse wrote:
> Try this patch to buildrom - it should make everybody happy.
> Jordan
>
> Jordan Crouse
> Systems Software Development Engineer 
> Advanced Micro Devices, Inc.
>
> !DSPAM:471fad6a90701804284693!
> [BUILDROM] Fix building 32 bit on 64 bit hosts
>
> Re-adjust my previous patch a little bit, its not smart to be passing the
> -m32 flag into the kernel, it already knows how to do the right thing (TM).
> So pull the 32 bit flags from the default CC, AS and LD variable and pass
> them in individually. Also, add quotes to the variables passed into the
> kernel, since thats obviously buggy.
>
> Signed-off-by: Jordan Crouse

Myles has confirmed (off-list) that this fixes the problem on 64 bit; I've
confirmed that it does not break 32 bit, hence:

Acked-by: Ward Vandewege

Thanks,
Ward.

[Jordan Crouse]

On 24/10/07 18:12 -0400, Ward Vandewege wrote:
> On Wed, Oct 24, 2007 at 02:38:42PM -0600, Jordan Crouse wrote:
> > Try this patch to buildrom - it should make everybody happy.
> > Jordan
> >
> > Jordan Crouse
> > Systems Software Development Engineer 
> > Advanced Micro Devices, Inc.
> >
> > !DSPAM:471fad6a90701804284693!
> > [BUILDROM] Fix building 32 bit on 64 bit hosts
> >
> > Re-adjust my previous patch a little bit, its not smart to be passing the
> > -m32 flag into the kernel, it already knows how to do the right thing (TM).
> > So pull the 32 bit flags from the default CC, AS and LD variable and pass
> > them in individually. Also, add quotes to the variables passed into the
> > kernel, since thats obviously buggy.
> >
> > Signed-off-by: Jordan Crouse
>
> Myles has confirmed (off-list) that this fixes the problem on 64 bit; I've
> confirmed that it does not break 32 bit, hence:
>
> Acked-by: Ward Vandewege

r49