workaround for mahogany_fam10. Not a signed-off-by

[Bao, Zheng]

This is for the mahogany_fam10 I just sent. It is not a signed-off-by
patch. We need to work it out about this problem.

Index: src/northbridge/amd/amdht/h3finit.c
===================================================================
--- src/northbridge/amd/amdht/h3finit.c	(revision 4521)
+++ src/northbridge/amd/amdht/h3finit.c	(working copy)
@@ -1104,6 +1104,7 @@
    			AmdPCIRead(currentPtr, &temp);
    		} while (!IS_HT_SLAVE_CAPABILITY(temp));

+#if (CONFIG_HT_CHAIN_UNITID_BASE != 0)
    		AmdPCIReadBits(currentPtr, 25, 21, &unitIDcnt);
    		if ((unitIDcnt + currentBUID > 31) || ((secBus
== 0) && (unitIDcnt + currentBUID > 24)))
    		{
@@ -1145,7 +1146,7 @@
    			STOP_HERE;
    			break;
    		}
-
+#endif
    		AmdPCIReadBits(currentPtr, 26, 26, &temp);
    		pDat->PortList[pDat->TotalLinks*2+1].Link =
(u8)temp;
    		pDat->PortList[pDat->TotalLinks*2+1].Pointer =
currentPtr;
@@ -1156,6 +1157,11 @@
    		depth++;
    		pDat->TotalLinks++;
    		currentBUID += unitIDcnt;
+#if CONFIG_HT_CHAIN_UNITID_BASE == 0
+			STOP_HERE;
+			break;
+#endif
+
    	}
    	if (pDat->HtBlock->AMD_CB_EventNotify)
    	{

[Marc Jones]

On Sun, Mar 14, 2010 at 11:41 PM, Bao, Zheng  wrote:
> This is for the mahogany_fam10 I just sent. It is not a signed-off-by
> patch. We need to work it out about this problem.
> Index: src/northbridge/amd/amdht/h3finit.c
>
> --- src/northbridge/amd/amdht/h3finit.c (revision 4521)
> +++ src/northbridge/amd/amdht/h3finit.c (working copy)
> @@ -1104,6 +1104,7 @@
>                                AmdPCIRead(currentPtr, &temp);
>                        } while (!IS_HT_SLAVE_CAPABILITY(temp));
>
> +#if (CONFIG_HT_CHAIN_UNITID_BASE != 0)
>                        AmdPCIReadBits(currentPtr, 25, 21, &unitIDcnt);
>                        if ((unitIDcnt + currentBUID > 31) || ((secBus
> == 0) && (unitIDcnt + currentBUID > 24)))
>                        {
> @@ -1145,7 +1146,7 @@
>                                STOP_HERE;
>                                break;
>                        }
>
> +#endif
>                        AmdPCIReadBits(currentPtr, 26, 26, &temp);
>                        pDat->PortList[pDat->TotalLinks*2+1].Link =
> (u8)temp;
>                        pDat->PortList[pDat->TotalLinks*2+1].Pointer =
> currentPtr;
> @@ -1156,6 +1157,11 @@
>                        depth++;
>                        pDat->TotalLinks++;
>                        currentBUID += unitIDcnt;
> +#if CONFIG_HT_CHAIN_UNITID_BASE == 0
> STOP_HERE;
> break;
>
> +#endif
>
> }
>                if (pDat->HtBlock->AMD_CB_EventNotify)
>                {

Please give a better description to this fix when you check it in.

Acked-by: Marc Jones

Thanks,
Marc

[Patrick Georgi]

Am 11.09.2010 00:55, schrieb Marc Jones:
> Please give a better description to this fix when you check it in.

Also, "Not a signed-off-by" is not the best condition to get it in.

Patrick

[Peter Stuge]

Patrick Georgi wrote:
> Am 11.09.2010 00:55, schrieb Marc Jones:
> > Please give a better description to this fix when you check it in.
>
> Also, "Not a signed-off-by" is not the best condition to get it in.

I guess it was not really intended to be commited but rather that
further work will come..

//Peter