change all references of lb_/LB_ to cb_/CB_ in flashrom
Signed-off-by: Sean Nelson snelson@nmt.edu
---
On Fri, Aug 08, 2008 at 10:00:39AM -0700, Sean Nelson wrote:
-static inline uint64_t unpack_lb64(struct lb_uint64 value) +static inline uint64_t unpack_lb64(struct cb_uint64 value) {
You missed the function names, but the rest looks good.
Can you send a new patch with that fixed?
//Peter
change all references of lb_/LB_ to cb_/CB_ in flashrom
Signed-off-by: Sean Nelson snelson@nmt.edu
---
functions in coreboot_tables.h have been converted in this patch
On Fri, Aug 8, 2008 at 1:21 PM, Peter Stuge peter@stuge.se wrote:
On Fri, Aug 08, 2008 at 10:00:39AM -0700, Sean Nelson wrote:
-static inline uint64_t unpack_lb64(struct lb_uint64 value) +static inline uint64_t unpack_lb64(struct cb_uint64 value) {
You missed the function names, but the rest looks good.
Can you send a new patch with that fixed?
//Peter
-- coreboot mailing list coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On Fri, Aug 08, 2008 at 10:21:55PM +0200, Peter Stuge wrote:
On Fri, Aug 08, 2008 at 10:00:39AM -0700, Sean Nelson wrote:
-static inline uint64_t unpack_lb64(struct lb_uint64 value) +static inline uint64_t unpack_lb64(struct cb_uint64 value) {
You missed the function names, but the rest looks good.
Can you send a new patch with that fixed?
Also, I'd rather not add an additional (C) for this patch, simple "fix typo"- or "whitespace-fixes"-style patches such as this don't warrant adding a (C) to the code (IMHO). (the other parts of your flashrom changes do, of course, as they're non-cosmetic and non-trivial).
Uwe.
removed (C)
On Fri, Aug 8, 2008 at 2:11 PM, Uwe Hermann uwe@hermann-uwe.de wrote:
On Fri, Aug 08, 2008 at 10:21:55PM +0200, Peter Stuge wrote:
On Fri, Aug 08, 2008 at 10:00:39AM -0700, Sean Nelson wrote:
-static inline uint64_t unpack_lb64(struct lb_uint64 value) +static inline uint64_t unpack_lb64(struct cb_uint64 value) {
You missed the function names, but the rest looks good.
Can you send a new patch with that fixed?
Also, I'd rather not add an additional (C) for this patch, simple "fix typo"- or "whitespace-fixes"-style patches such as this don't warrant adding a (C) to the code (IMHO). (the other parts of your flashrom changes do, of course, as they're non-cosmetic and non-trivial).
Uwe.
http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-- coreboot mailing list coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On 08.08.2008 19:00, Sean Nelson wrote:
change all references of lb_/LB_ to cb_/CB_ in flashrom
Signed-off-by: Sean Nelson snelson@nmt.edu
Your mailer seems to be broken. Giving the attachment the type application/octet-stream is inappropriate for plain text patches and causes at least Thunderbird not to display the attachment inline.
Regards, Carl-Daniel
patch named .diff; should show inline
On Fri, Aug 8, 2008 at 4:29 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
On 08.08.2008 19:00, Sean Nelson wrote:
change all references of lb_/LB_ to cb_/CB_ in flashrom
Signed-off-by: Sean Nelson snelson@nmt.edu
Your mailer seems to be broken. Giving the attachment the type application/octet-stream is inappropriate for plain text patches and causes at least Thunderbird not to display the attachment inline.
Regards, Carl-Daniel
-
Carl-Daniel Hailfinger -
Peter Stuge -
Sean Nelson -
Uwe Hermann