Bug?: Value in .config overwritten during make (Thinkpad T400/T500)

[Daniel Kulesz]

Hi folks,

after several hours of trial & error I finally realized why the quadcore CPU in my T500 does not get recognized: No matter what you set for MAX_CPUS in .config, it gets overwritten during the build with a value coming from

src/mainboard/lenovo/t400

where the following is defined:

config MAX_CPUS
        int
        default 2

Well, at least for me default means that it's a default, not that it overwrites the actual config. Is this behavior really intended?

Cheers, Daniel

[Nico Huber]

Hi Daniel,

On 13.11.2016 19:22, Daniel Kulesz via coreboot wrote:
> Hi folks,
>
> after several hours of trial & error I finally realized why the quadcore
> CPU in my T500 does not get recognized: No matter what you set for
> MAX_CPUS in .config, it gets overwritten during the build with a value
> coming from
>
> src/mainboard/lenovo/t400
>
> where the following is defined:
>
> config MAX_CPUS int default 2
>
> Well, at least for me default means that it's a default, not that it
> overwrites the actual config. Is this behavior really intended?

what do you mean by `actual config`? how did you set it? If you edi-
ted .config manually, it's intended behavior. MAX_CPUS doesn't have
a prompt so it's not user visible / settable.

Nico

[Daniel Kulesz]

Hi Nico and Martin,

thank you for your clarifications and the pointer to the documentation.

On Sun, 13 Nov 2016 22:46:48 +0100
Nico Huber  wrote:
> what do you mean by `actual config`? how did you set it? If you edi-
> ted .config manually, it's intended behavior. MAX_CPUS doesn't have
> a prompt so it's not user visible / settable.

Indeed, I meant the .config file which I edited manually to set the number of CPUs. So I see, to make the T400/T500 systems support both Dual- and Quadcore CPUs I would need to make this setting get a prompt/select then (if not using Kconfig hardcoding of course).

Cheers, Daniel