Re: [LinuxBIOS] r386 - in LinuxBIOSv3/arch/x86: . geodelx

[Peter Stuge]

On Wed, Jun 27, 2007 at 11:01:01PM +0200, [e-mail] wrote:
> +struct constructor geodelx_constructors[] = {
> {.id = {.type = DEVICE_ID_PCI,
>  .u = {.pci = {.vendor = X86_VENDOR_AMD,.device = 0x05A2}}},
> .ops = &geodelx_cpuops},
> {.ops = 0},
>
> +};

Did this get changed to better PCI ID #defines already?

//Peter

[LinuxBIOS] r386 - in LinuxBIOSv3/arch/x86: . geodelx

[Uwe Hermann]

On Thu, Jun 28, 2007 at 01:08:28AM +0200, Peter Stuge wrote:
> On Wed, Jun 27, 2007 at 11:01:01PM +0200, [e-mail] wrote:
> > +struct constructor geodelx_constructors[] = {
> > {.id = {.type = DEVICE_ID_PCI,
> >  .u = {.pci = {.vendor = X86_VENDOR_AMD,.device = 0x05A2}}},
> > .ops = &geodelx_cpuops},
> > {.ops = 0},
> >
> > +};
>
> Did this get changed to better PCI ID #defines already?

I'm not even sure it works this way. X86_VENDOR_AMD is not a PCI vendor
ID, it's simply a 3, see cpu.h. As this uses ".type = DEVICE_ID_PCI"
I doubt it'll work. We probably need some DEVICE_ID_CPU or something?

Uwe.

[LinuxBIOS] [[e-mail]: Re: r386 - in LinuxBIOSv3/arch/x86: . geodelx]

[Uwe Hermann]

[I think this was only sent to me, not the list, so I'm forwarding...]

----- Forwarded message from Marc Jones  -----

From: Marc Jones 
To: Uwe Hermann 
Subject: Re: [LinuxBIOS] r386 - in LinuxBIOSv3/arch/x86: . geodelx
Date: Wed, 27 Jun 2007 23:11:50 -0600

Uwe Hermann wrote:
> On Thu, Jun 28, 2007 at 01:08:28AM +0200, Peter Stuge wrote:
> > On Wed, Jun 27, 2007 at 11:01:01PM +0200, [e-mail] wrote:
> > > +struct constructor geodelx_constructors[] = {
> > > {.id = {.type = DEVICE_ID_PCI,
> > >  .u = {.pci = {.vendor = X86_VENDOR_AMD,.device = 0x05A2}}},
> > > .ops = &geodelx_cpuops},
> > > {.ops = 0},
> > >
> > > +};
> >
> > Did this get changed to better PCI ID #defines already?
>
> I'm not even sure it works this way. X86_VENDOR_AMD is not a PCI vendor
> ID, it's simply a 3, see cpu.h. As this uses ".type = DEVICE_ID_PCI"
> I doubt it'll work. We probably need some DEVICE_ID_CPU or something?

Uwe is correct. The 0x5a2 is returned from a CPUID eax=0x01 
instructions. I think that it is defined lxdef.h.
Marc

----- End forwarded message -----

Uwe.

[LinuxBIOS] [[e-mail]: Re: r386 - in LinuxBIOSv3/arch/x86: . geodelx]

[Stefan Reinauer]

* Uwe Hermann  [070628 15:33]:
> > I'm not even sure it works this way. X86_VENDOR_AMD is not a PCI vendor
> > ID, it's simply a 3, see cpu.h. As this uses ".type = DEVICE_ID_PCI"
> > I doubt it'll work. We probably need some DEVICE_ID_CPU or something?
>
> Uwe is correct. The 0x5a2 is returned from a CPUID eax=0x01 
> instructions. I think that it is defined lxdef.h.
> Marc

I second that. Patch anyone?