Re: [LinuxBIOS] r380 - LinuxBIOSv3/superio/winbond/w83627hf

[Uwe Hermann]

> Modified: LinuxBIOSv3/superio/winbond/w83627hf/w83627hf.h
>
> --- LinuxBIOSv3/superio/winbond/w83627hf/w83627hf.h	2007-06-27 20:02:43 UTC (rev 379)
> +++ LinuxBIOSv3/superio/winbond/w83627hf/w83627hf.h	2007-06-27 20:09:47 UTC (rev 380)
> @@ -12,83 +12,4 @@
>  #define W83627HF_GPIO3            9
>  #define W83627HF_ACPI            10
>  #define W83627HF_HWM             11   /* Hardware Monitor */

The file is trivial but missing a license header. Please
add one with yourself as sole copyright owner.
> Modified: LinuxBIOSv3/superio/winbond/w83627hf/w83627hf_early_serial.c
>
> --- LinuxBIOSv3/superio/winbond/w83627hf/w83627hf_early_serial.c	2007-06-27 20:02:43 UTC (rev 379)
> +++ LinuxBIOSv3/superio/winbond/w83627hf/w83627hf_early_serial.c	2007-06-27 20:09:47 UTC (rev 380)
> @@ -1,22 +1,36 @@
> +/*
> This file is part of the LinuxBIOS project.
> Copyright 2000  AG Electronics Ltd.
> Copyright 2003-2004 Linux Networx
> Copyright 2004 Tyan
> By LYH change from PC87360
> Copyright 2007 coresystems GmbH

Nope, this is
Copyright (C) 2007 Ronald G. Minnich

It's completely new code and trivial anyway.
> -static inline void pnp_enter_ext_func_mode(struct device *dev) 
> +void w83627hf_enable_serial(u8 dev, u8 serial, u16 iobase)

The "serial" is a bit generic/misleading? Any more precise name?

Uwe.