Re: [LinuxBIOS] MCP55 LinuxBIOS with USB debug etc. part 1

[Lu, Yinghai]

Too much difference. May take several days to produce patch.

YH

-----Original Message-----
From: Stefan Reinauer [mailto:[e-mail]] 
Sent: Friday, January 19, 2007 10:08 AM
To: Lu, Yinghai
Cc: [e-mail]
Subject: Re: [LinuxBIOS] MCP55 LinuxBIOS with USB debug etc. part 1

* Lu, Yinghai  [070119 18:44]:
> -----Original Message-----
> From: Lu, Yinghai 
> Sent: Thursday, January 18, 2007 9:06 PM
> To: 'Ronald G Minnich'; Eric W. Biederman
> Cc: [e-mail]
> Subject: MCP55 LinuxBIOS with USB debug etc.
>
> Please check the MCP55 support with usbdebug.
>
> MB included:
> Nvidia l1_2pvv
> Gigabyte m57sli
> Supermicro h8dmr
> Tyan s2912 --- with HTX
>
> Signed-off-by: Yinghai Lu

Wow! Impressive. Thank you very much for your contribution.

Is there any chance you can send this as patches, or just the new
files?

What's the difference between the archives?

[LinuxBIOS] MCP55 LinuxBIOS with USB debug etc. part 1

[Uwe Hermann]

Hi,

great work Yinghai! Thanks a lot!

Here's the whole blob in patch format (only 'nsf' and
'readme_mcp55.txt' are missing from the patch; I attached them as single
files to this mail).

Please do _not_ commit this as is. We should split this up in several
small, independent patches, then review and test (as far as
possible) all of them. The issue tracker will be very useful for this,
IHMO we should create an issue for every sub-patch...

Also, please note that some of the contents of the patch are old and
obsolete (i.e. svn trunk contains newer code, see for example the
util/flashrom/* stuff). Most of those parts can be safely ignored
(after a careful review of the changes), I guess.

HTH, Uwe.

[LinuxBIOS] MCP55 LinuxBIOS with USB debug etc. part 1

[yhlu]

Thanks.

Please don't forget

On 1/20/07, Uwe Hermann  wrote:
> Hi,
>
> great work Yinghai! Thanks a lot!
>
> Here's the whole blob in patch format (only 'nsf' and
> 'readme_mcp55.txt' are missing from the patch; I attached them as single
> files to this mail).
>
> Please do _not_ commit this as is. We should split this up in several
> small, independent patches, then review and test (as far as
> possible) all of them. The issue tracker will be very useful for this,
> IHMO we should create an issue for every sub-patch...
>
> Also, please note that some of the contents of the patch are old and
> obsolete (i.e. svn trunk contains newer code, see for example the
> util/flashrom/* stuff). Most of those parts can be safely ignored
> (after a careful review of the changes), I guess.
> HTH, Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFFsj33XdVoV3jWIbQRAj6zAJsGxtnusq90B3PICZTHencTqSzskQCghaEh
> VlrhTHz62f/ktktm9Y+WJak=
> =g+2u
> -----END PGP SIGNATURE-----

[LinuxBIOS] MCP55 LinuxBIOS with USB debug etc. part 1

[yhlu]

Please don't forget mcp55 support in util/flashrom.

YH

On 1/20/07, yhlu  wrote:
> Thanks.
>
> Please don't forget
>
> On 1/20/07, Uwe Hermann  wrote:
> > Hi,
> >
> > great work Yinghai! Thanks a lot!
> >
> > Here's the whole blob in patch format (only 'nsf' and
> > 'readme_mcp55.txt' are missing from the patch; I attached them as single
> > files to this mail).
> >
> > Please do _not_ commit this as is. We should split this up in several
> > small, independent patches, then review and test (as far as
> > possible) all of them. The issue tracker will be very useful for this,
> > IHMO we should create an issue for every sub-patch...
> >
> > Also, please note that some of the contents of the patch are old and
> > obsolete (i.e. svn trunk contains newer code, see for example the
> > util/flashrom/* stuff). Most of those parts can be safely ignored
> > (after a careful review of the changes), I guess.
> > HTH, Uwe.
> >
> > http://www.hermann-uwe.de  | http://www.holsham-traders.de
> > http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
> >
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.6 (GNU/Linux)
> >
> > iD8DBQFFsj33XdVoV3jWIbQRAj6zAJsGxtnusq90B3PICZTHencTqSzskQCghaEh
> > VlrhTHz62f/ktktm9Y+WJak=
> > =g+2u
> > -----END PGP SIGNATURE-----

[LinuxBIOS] MCP55 LinuxBIOS with USB debug etc. part 1

[Ed Swierk]

On 1/20/07, Uwe Hermann  wrote:
> great work Yinghai! Thanks a lot!

Yes, it's great to see some code finally getting released. My own code
is still stuck somewhere in nVidia legal limbo, but it's mainly a
subset of Yinghai's except for the particular mainboard (DFI LANParty)
support.
> Please do _not_ commit this as is. We should split this up in several
> small, independent patches, then review and test (as far as
> possible) all of them. The issue tracker will be very useful for this,
> IHMO we should create an issue for every sub-patch...

Also there's a lot of overlap between the new code and the existing
code in src/southbridge/nvidia/ck804. In some cases the only
differences are a few constants. It would be unfortunate if every time
nVidia releases a new chipset (MCP65 is just around the corner!) we
ended up with another copy of almost the same code.

This issue is probably not important enough to block committing the
code if it's otherwise okay. Maybe the best thing would be just to
open a tracker issue for this, i.e. merging mcp55 and ck804 code into
a more generic "nforce" southbridge. I can spend some time on this but
can't promise to do it all myself.

--Ed

[LinuxBIOS] MCP55 LinuxBIOS with USB debug etc. part 1

[Uwe Hermann]

Hi,

On Mon, Jan 22, 2007 at 10:38:37AM -0800, Ed Swierk wrote:
> This issue is probably not important enough to block committing the
> code if it's otherwise okay. Maybe the best thing would be just to
> open a tracker issue for this, [...]

Done: http://tracker.linuxbios.org/trac/LinuxBIOS/ticket/73

Uwe.