New patch to review for coreboot: bebe95d Intel 82810 and 82830: always room for PCI memory

[Kyösti Mälkki]

Kyösti Mälkki ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1369

-gerrit

commit bebe95db1a971eae1658f70c9be13d59a7ea0650
Author: Kyösti Mälkki 
Date:   Fri Jul 27 08:40:46 2012 +0300

Intel 82810 and 82830: always room for PCI memory

No need for the test, tomk is at most 1GB on these chipsets.
    Even if there was no room, adjusting the memory resource would not
    not divert accesses in the hardware from DRAM to PCI.

Change-Id: I2213b8d9d2e6ab8da8fd3e8081cc62bb05b6b316
    Signed-off-by: Kyösti Mälkki 
---
 src/northbridge/intel/i82810/northbridge.c |   13 ++-----------
 src/northbridge/intel/i82830/northbridge.c |   13 ++-----------
 2 files changed, 4 insertions(+), 22 deletions(-)

diff --git a/src/northbridge/intel/i82810/northbridge.c b/src/northbridge/intel/i82810/northbridge.c
index 3337417..892fc28 100644
--- a/src/northbridge/intel/i82810/northbridge.c
+++ b/src/northbridge/intel/i82810/northbridge.c
@@ -87,15 +87,13 @@ static int translate_i82810_to_mb[] = {
 static void pci_domain_set_resources(device_t dev)
 {
    device_t mc_dev;
-	uint32_t pci_tolm;
    int igd_memory = 0;

-	pci_tolm = find_pci_tolm(dev->link_list);
    mc_dev = dev->link_list->children;
    if (!mc_dev)
    	return;

-	unsigned long tomk, tolmk;
+	unsigned long tomk;
    int idx, drp_value;
    u8 reg8;

@@ -132,17 +130,10 @@ static void pci_domain_set_resources(device_t dev)
    uma_memory_size = igd_memory * 1024ULL;
    printk(BIOS_DEBUG, "Available memory: %ldKB\n", tomk);

-	/* Compute the top of low memory. */
-	tolmk = pci_tolm >> 10;
-	if (tolmk >= tomk) {
-		/* The PCI hole does does not overlap the memory. */
-		tolmk = tomk;
-	}
-
    /* Report the memory regions. */
    idx = 10;
    ram_resource(dev, idx++, 0, 640);
-	ram_resource(dev, idx++, 768, tolmk - 768);
+	ram_resource(dev, idx++, 768, tomk - 768);

#if CONFIG_WRITE_HIGH_TABLES
    /* Leave some space for ACPI, PIRQ and MP tables */
diff --git a/src/northbridge/intel/i82830/northbridge.c b/src/northbridge/intel/i82830/northbridge.c
index 22f59dc..4ada4d7 100644
--- a/src/northbridge/intel/i82830/northbridge.c
+++ b/src/northbridge/intel/i82830/northbridge.c
@@ -67,15 +67,13 @@ int add_northbridge_resources(struct lb_memory *mem)
 static void pci_domain_set_resources(device_t dev)
 {
    device_t mc_dev;
-	uint32_t pci_tolm;
    int igd_memory = 0;

-	pci_tolm = find_pci_tolm(dev->link_list);
    mc_dev = dev->link_list->children;
    if (!mc_dev)
    	return;

-	unsigned long tomk, tolmk;
+	unsigned long tomk;
    int idx;

if (CONFIG_VIDEO_MB == 512) {
@@ -98,18 +96,11 @@ static void pci_domain_set_resources(device_t dev)
    uma_memory_size = igd_memory * 1024ULL;
    printk(BIOS_DEBUG, "Available memory: %ldKB\n", tomk);

-	/* Compute the top of low memory. */
-	tolmk = pci_tolm >> 10;
-	if (tolmk >= tomk) {
-		/* The PCI hole does does not overlap the memory. */
-		tolmk = tomk;
-	}
-
    /* Report the memory regions. */
    idx = 10;
    ram_resource(dev, idx++, 0, 640);
    ram_resource(dev, idx++, 768, 256);
-	ram_resource(dev, idx++, 1024, tolmk - 1024);
+	ram_resource(dev, idx++, 1024, tomk - 1024);

assign_resources(dev->link_list);