Hi,
Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.
2 new defect(s) introduced to coreboot found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s)
** CID 1383919: Resource leaks (RESOURCE_LEAK) /util/cbfstool/partitioned_file.c: 201 in partitioned_file_reopen()
________________________________________________________________________________________________________ *** CID 1383919: Resource leaks (RESOURCE_LEAK) /util/cbfstool/partitioned_file.c: 201 in partitioned_file_reopen() 195 } 196 197 const struct fmap_area *fmap_fmap_entry = 198 fmap_find_area(file->fmap, SECTION_NAME_FMAP); 199 200 if (!fmap_fmap_entry)
CID 1383919: Resource leaks (RESOURCE_LEAK) Variable "file" going out of scope leaks the storage it points to.
201 return NULL; 202 203 if ((long)fmap_fmap_entry->offset != fmap_region_offset) { 204 ERROR("FMAP's '%s' section doesn't point back to FMAP start (did something corrupt this file?)\n", 205 SECTION_NAME_FMAP); 206 partitioned_file_close(file);
** CID 1383918: Incorrect expression (MIXED_ENUMS) /src/southbridge/intel/common/rcba_pirq.c: 30 in intel_common_map_pirq()
________________________________________________________________________________________________________ *** CID 1383918: Incorrect expression (MIXED_ENUMS) /src/southbridge/intel/common/rcba_pirq.c: 30 in intel_common_map_pirq() 24 slot, pci_pin); 25 return PIRQ_NONE; 26 } 27 28 if (slot < MIN_SLOT || slot > MAX_SLOT) { 29 /* non-PCH devices use 1:1 mapping. */
CID 1383918: Incorrect expression (MIXED_ENUMS) Mixing enum types "enum pci_pin" and "enum pirq" for "pci_pin".
30 return pci_pin; 31 } 32 33 reg = pirq_dir_route_reg[slot - MIN_SLOT]; 34 35 pirq = ((RCBA16(reg) >> shift) & 0xf);
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...
To manage Coverity Scan email notifications for "coreboot@coreboot.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...