When I build coreboot 4.5 from the release sources it is necessary to download the coreboot-blobs-4.5.tar.xz file and it looks like there might be a dependency now on the 3rdparty/vboot tree as well since cbfs.h includes vb2_api.h:
https://github.com/coreboot/coreboot/blob/master/src/commonlib/include/commo...
When building from git it checks out the correct submodule, so this is only a problem for me with releases. Is there an official release tar for vboot sources? I don't see one in https://www.coreboot.org/releases/.
Trammell Hudson wrote:
When I build coreboot 4.5 from the release sources it is necessary to download the coreboot-blobs-4.5.tar.xz file and it looks like there might be a dependency now on the 3rdparty/vboot tree as well since cbfs.h includes vb2_api.h:
https://github.com/coreboot/coreboot/blob/master/src/commonlib/include/commo...
This seems like a bug to me. I think the vboot header should either be conditionally included according to configuration, or if it's an ABI then I would suggest to keep a local copy. I assume the ABI is versioned, so back+forward compatibility should be no problem.
//Peter
On Thu, Jan 5, 2017 at 1:45 PM, Peter Stuge peter@stuge.se wrote:
Trammell Hudson wrote:
When I build coreboot 4.5 from the release sources it is necessary to download the coreboot-blobs-4.5.tar.xz file and it looks like there might be a dependency now on the 3rdparty/vboot tree as well since cbfs.h includes vb2_api.h:
https://github.com/coreboot/coreboot/blob/master/src/commonlib/include/commo...
This seems like a bug to me. I think the vboot header should either be conditionally included according to configuration, or if it's an ABI then I would suggest to keep a local copy. I assume the ABI is versioned, so back+forward compatibility should be no problem.
Whether or not that include is removed from that file doesn't matter. cbfstool uses vb2 for the hashing routines internally -- as well as coreboot proper. This was discussed around a month ago on #coreboot, iirc. I don't recall with whom aside from Damien, but people were going to look into providing a crypto interface that can be implemented for hashing, etc. This CL spawned that discussion: https://review.coreboot.org/#/c/17469/ However, I haven't seen that work at all yet.
I tried removing that API a while back, but I can't find that CL. I'm not sure why. I think Zaolin wanted that API. Here's a CL to remove it that will fail to build because of what I described: https://review.coreboot.org/18045
//Peter
-- coreboot mailing list: coreboot@coreboot.org https://www.coreboot.org/mailman/listinfo/coreboot
On Thu, Jan 05, 2017 at 06:34:42AM -0700, Trammell Hudson wrote:
When I build coreboot 4.5 from the release sources it is necessary to download the coreboot-blobs-4.5.tar.xz file and it looks like there might be a dependency now on the 3rdparty/vboot tree as well since cbfs.h includes vb2_api.h [...]
Ah, I see what happened. My script fetched the tar file from the github release tag:
https://github.com/coreboot/coreboot/archive/4.5.tar.gz
Instead of fetching from the official release server:
https://www.coreboot.org/releases/coreboot-4.5.tar.xz
That's why the submodules are not included in the source tar.
What's the distinction between coreboot/src/vboot and the coreboot/3rdparty/vboot directories? As Peter pointed out, having the necessary headers self contained in the coreboot tree would be nice to have.
-- Trammell
On Thu, Jan 5, 2017 at 3:28 PM, Trammell Hudson hudson@trmm.net wrote:
On Thu, Jan 05, 2017 at 06:34:42AM -0700, Trammell Hudson wrote:
When I build coreboot 4.5 from the release sources it is necessary to download the coreboot-blobs-4.5.tar.xz file and it looks like there might be a dependency now on the 3rdparty/vboot tree as well since cbfs.h includes vb2_api.h [...]
Ah, I see what happened. My script fetched the tar file from the github release tag:
https://github.com/coreboot/coreboot/archive/4.5.tar.gz
Instead of fetching from the official release server:
https://www.coreboot.org/releases/coreboot-4.5.tar.xz
That's why the submodules are not included in the source tar.
What's the distinction between coreboot/src/vboot and the coreboot/3rdparty/vboot directories? As Peter pointed out, having the necessary headers self contained in the coreboot tree would be nice to have.
src/vboot calls into 3rdparty/vboot. src/vboot is the runtime binding for the vboot implementation. That's orthogonal to the other utility functions vboot supplies that the coreboot uses (hashing constructs). I hope that helps.
-- Trammell
-- coreboot mailing list: coreboot@coreboot.org https://www.coreboot.org/mailman/listinfo/coreboot
-
Aaron Durbin -
Peter Stuge -
Trammell Hudson