答复: S4882 Support Done

[YhLu]

Stefan thanks.

1. hard_reset, with my two patch, the s4880 and 2885 with deferent link to
amd8131 and more links to in coherent devices can make ht-reset works. You
can keep the hard-reset, but some time it cause trouble.
2. sio-enable, because the init is not called. Without the init_keyboard,
the keyboard will not work under kernel 2.6.3 or later.

Regards

YH

-----邮件原件-----
发件人: Stefan Reinauer [mailto:[e-mail]] 
发送时间: 2004年3月25日 1:51
收件人: YhLu
抄送: ron minnich; [e-mail]; [e-mail]
主题: Re: S4882 Support Done

* YhLu  [040324 22:19]:
> Please commit the s4882 support code.
> Add S4882 support.
> Modify auto.c for s2881, s2885, s4880.
> Add some optimize_link calling in set_smp.

it's committed, except two small things:

* src/devices/hypertransport.c:
  -               hard_reset();
  +// by LYH              hard_reset();

it'd be better to fix this issue so we don't walk into that code path
anymore at all.

* src/superio/winbond/w83627hf/superio.c

Why did this not have a sio_enable before? Is it really needed?

Stefan

[ron minnich]

On Thu, 25 Mar 2004, YhLu wrote:
> sio-enable, because the init is not called. Without the init_keyboard,
>
> the keyboard will not work under kernel 2.6.3 or later.

Oops, just read the patch and I don't see any problem with it.

Stefan, what was the concern?

Sorry, too much going on here.

ron

????: S4882 Support Done

[Stefan Reinauer]

* ron minnich  [040325 18:43]:
> Oops, just read the patch and I don't see any problem with it.
>
> Stefan, what was the concern?

I was just not sure what made the code necessary.. it's in now.

Stefan

????: S4882 Support Done

[Stefan Reinauer]

* YhLu  [040325 18:48]:
> hard_reset, with my two patch, the s4880 and 2885 with deferent link to
>
> amd8131 and more links to in coherent devices can make ht-reset works. You
> can keep the hard-reset, but some time it cause trouble.

ok. we have to find a solution here..
> sio-enable, because the init is not called. Without the init_keyboard,
>
> the keyboard will not work under kernel 2.6.3 or later.

Commited.

Stefan