On 02.12.2008 13:26, svn@coreboot.org wrote:
Author: stepan Date: 2008-12-02 13:26:17 +0100 (Tue, 02 Dec 2008) New Revision: 3789
Modified: trunk/coreboot-v2/util/options/build_opt_tbl.c Log: build_opt_tbl: make sure the temporary files are created in the same directory as the target files so they can be rename()d. This fixes a compilation issue on machines with the build directory living on another partition than /tmp. Pretty trivial.
Signed-off-by: Stefan Reinauer stepan@coresystems.de Acked-by: Stefan Reinauer stepan@coresystems.de
This will break if the path is longer than 234 bytes, whereas PATH_MAX on my Linux system is 4096.
Regards, Carl-Daniel
Carl-Daniel Hailfinger wrote:
This will break if the path is longer than 234 bytes, whereas PATH_MAX on my Linux system is 4096.
Would obviously rock if you sent a patch too. :)
//Peter
On 02.12.2008 14:02, Peter Stuge wrote:
Carl-Daniel Hailfinger wrote:
This will break if the path is longer than 234 bytes, whereas PATH_MAX on my Linux system is 4096.
Would obviously rock if you sent a patch too. :)
Sure, I already did that. See "[coreboot] [PATCH] Avoid cross-device renames in build_opt_tbl".
Should I revert r3789 and apply my patch instead? Or is a fusion of both patches preferred?
Regards, Carl-Daniel
On 02.12.2008 14:28, Carl-Daniel Hailfinger wrote:
On 02.12.2008 14:02, Peter Stuge wrote:
Carl-Daniel Hailfinger wrote:
This will break if the path is longer than 234 bytes, whereas PATH_MAX on my Linux system is 4096.
Would obviously rock if you sent a patch too. :)
Sure, I already did that. See "[coreboot] [PATCH] Avoid cross-device renames in build_opt_tbl".
Should I revert r3789 and apply my patch instead? Or is a fusion of both patches preferred?
I sent a followup patch.
Regards, Carl-Daniel
-
Carl-Daniel Hailfinger -
Peter Stuge