Re: [coreboot] ACPI Errors on Lenovo X201i

[Patrick Rudolph]

Hi Matthias,
on my T430 it works fine. My ssdt.dsl shows

Scope (_SB.PCI0.LPCB.EC.HKEY)
{
    Name (HBDC, 0x01)
}

I guess the reason that it's not working on x201 is the devicetree.cb.

Please test this patch https://review.coreboot.org/#/c/coreboot/+/27481
/ , it should fix the issue.

Regards,
Patrick

On Sat, 2018-07-14 at 15:08 +0200, Matthias Gazzari wrote:
> Hi Patrick,
>
> I see the following occurrence of HBDC in the ssdt.dsl (decompiled from
> /sys/firmware/acpi/tables/SSDT, is that the right file?) just below the
> scope of the main DefinitionBlock:
>
> Scope (_SB.EC.HKEY)
> {
>     Name (HBDC, 0x00)
> }
>
> Additionally, I have got this warning: "iASL Warning: There were 2
> external control methods found during disassembly, but only 0 were
> resolved (2 unresolved)." Not sure if that is relevant for this issue.
>
> Cheers,
> Matthias
>
> On 14/07/18 08:55, Patrick Rudolph wrote:
> > Hi Matthias,
> > The dsdt.dsl is a static file, generated at build time. The ssdt.dsl is generated at each boot.
> > Is there a HBDC in the ssdt.dsl  under the same scope ?
> > Regards Patrick
> >
> > Am 14. Juli 2018 00:08:09 MESZ schrieb Matthias Gazzari :
> > > Hi Patrick,
> > >
> > > I built with the current origin/master, so the Nehalem fix
> > > https://review.coreboot.org/#/c/coreboot/+/26287/ is already included.
> > > I
> > > see "ACPI:    * H8" and have the following mentions of HBDC inside the
> > > dsdt.dsl:
> > >
> > > External (HBDC, IntObj)
> > >
> > > and
> > >
> > > Method (GBDC, 0, NotSerialized)
> > > {
> > >    If (HBDC)
> > >    {
> > >    	Local0 = One
> > >    	If (BTEB)
> > >    	{
> > >    		Local0 |= 0x02
> > >    	}
> > > Local0 |= 0x04
> > > Return (Local0)
> > >
> > > }
> > >    Else
> > >    {
> > >    	Return (Zero)
> > >    }
> > > }
> > >
> > > Method (SBDC, 1, NotSerialized)
> > > {
> > >    If (HBDC)
> > >    {
> > >    	Local0 = ((Arg0 & 0x02) >> One)
> > >    	BTEB = Local0
> > >    }
> > > }
> > >
> > > Hope that helps.
> > >
> > > Cheers,
> > > Matthias
> > >
> > > On 13/07/18 23:41, Patrick Rudolph wrote:
> > > > Hi Matthias,
> > > > It looks like the Ssdt generator on x201/nehalem doesn't work as
> > >
> > > expected.
> > > > It was broken and has been fixed in commit
> > >
> > > https://review.coreboot.org/#/c/coreboot/+/26287/
> > > > Do you see "ACPI:    * H8" in coreboot console log ?
> > > > Do you see any HBDC method in disassembled ACPI ?
> > > > Regards Patrick
> > > >
> > > > Am 13. Juli 2018 22:46:12 MESZ schrieb Matthias Gazzari
> > >
> > > :
> > > > > Hello,
> > > > >
> > > > > commit f1114d891865e70ae1f2ba58844fec11d055ae3a (ec/lenovo/h8/acpi:
> > >
> > > Add
> > > > > BDC interface) introduces the following ACPI errors on the Lenovo
> > > > > X201i:
> > > > >
> > > > > ACPI BIOS Error (bug): Could not resolve [_SB.EC.HKEY],
> > >
> > > AE_NOT_FOUND
> > > > > (20180313/dswload2-160)
> > > > > ACPI Error: AE_NOT_FOUND, During name lookup/catalog
> > > > > (20180313/psobject-221)
> > > > > ACPI Error: Ignore error and continue table load
> > > > > (20180313/psobject-604)
> > > > > ACPI Error: Skipping Scope block (20180313/psloop-532)
> > > > >
> > > > > and
> > > > >
> > > > > ACPI BIOS Error (bug): Could not resolve
> > > > > [_SB.PCI0.LPCB.EC.HKEY.GBDC.HBDC], AE_NOT_FOUND
> > >
> > > (20180313/psargs-330)
> > > > > ACPI Error: Method parse/execution failed
> > >
> > > _SB.PCI0.LPCB.EC.HKEY.GBDC,
> > > > > AE_NOT_FOUND (20180313/psparse-516)
> > > > >
> > > > > Do you have any idea on how to fix these issues?
> > > > >
> > > > > Cheers,
> > > > > Matthias

ACPI Errors on Lenovo X201i

[Matthias Gazzari]

Hi Patrick,

it fixed the issue, many thanks!

Cheers,
Matthias

On 14/07/18 16:51, Patrick Rudolph wrote:
> Hi Matthias,
> on my T430 it works fine. My ssdt.dsl shows
>
> Scope (_SB.PCI0.LPCB.EC.HKEY)
> {
>     Name (HBDC, 0x01)
> }
>
> I guess the reason that it's not working on x201 is the devicetree.cb.
>
> Please test this patch https://review.coreboot.org/#/c/coreboot/+/27481
> / , it should fix the issue.
>
> Regards,
> Patrick
>
> On Sat, 2018-07-14 at 15:08 +0200, Matthias Gazzari wrote:
> > Hi Patrick,
> >
> > I see the following occurrence of HBDC in the ssdt.dsl (decompiled from
> > /sys/firmware/acpi/tables/SSDT, is that the right file?) just below the
> > scope of the main DefinitionBlock:
> >
> > Scope (_SB.EC.HKEY)
> > {
> >     Name (HBDC, 0x00)
> > }
> >
> > Additionally, I have got this warning: "iASL Warning: There were 2
> > external control methods found during disassembly, but only 0 were
> > resolved (2 unresolved)." Not sure if that is relevant for this issue.
> >
> > Cheers,
> > Matthias
> >
> > On 14/07/18 08:55, Patrick Rudolph wrote:
> > > Hi Matthias,
> > > The dsdt.dsl is a static file, generated at build time. The ssdt.dsl is generated at each boot.
> > > Is there a HBDC in the ssdt.dsl  under the same scope ?
> > > Regards Patrick
> > >
> > > Am 14. Juli 2018 00:08:09 MESZ schrieb Matthias Gazzari :
> > > > Hi Patrick,
> > > >
> > > > I built with the current origin/master, so the Nehalem fix
> > > > https://review.coreboot.org/#/c/coreboot/+/26287/ is already included.
> > > > I
> > > > see "ACPI:    * H8" and have the following mentions of HBDC inside the
> > > > dsdt.dsl:
> > > >
> > > > External (HBDC, IntObj)
> > > >
> > > > and
> > > >
> > > > Method (GBDC, 0, NotSerialized)
> > > > {
> > > >    If (HBDC)
> > > >    {
> > > >    	Local0 = One
> > > >    	If (BTEB)
> > > >    	{
> > > >    		Local0 |= 0x02
> > > >    	}
> > > > Local0 |= 0x04
> > > > Return (Local0)
> > > >
> > > > }
> > > >    Else
> > > >    {
> > > >    	Return (Zero)
> > > >    }
> > > > }
> > > >
> > > > Method (SBDC, 1, NotSerialized)
> > > > {
> > > >    If (HBDC)
> > > >    {
> > > >    	Local0 = ((Arg0 & 0x02) >> One)
> > > >    	BTEB = Local0
> > > >    }
> > > > }
> > > >
> > > > Hope that helps.
> > > >
> > > > Cheers,
> > > > Matthias
> > > >
> > > > On 13/07/18 23:41, Patrick Rudolph wrote:
> > > > > Hi Matthias,
> > > > > It looks like the Ssdt generator on x201/nehalem doesn't work as
> > > >
> > > > expected.
> > > > > It was broken and has been fixed in commit
> > > >
> > > > https://review.coreboot.org/#/c/coreboot/+/26287/
> > > > > Do you see "ACPI:    * H8" in coreboot console log ?
> > > > > Do you see any HBDC method in disassembled ACPI ?
> > > > > Regards Patrick
> > > > >
> > > > > Am 13. Juli 2018 22:46:12 MESZ schrieb Matthias Gazzari
> > > >
> > > > :
> > > > > > Hello,
> > > > > >
> > > > > > commit f1114d891865e70ae1f2ba58844fec11d055ae3a (ec/lenovo/h8/acpi:
> > > >
> > > > Add
> > > > > > BDC interface) introduces the following ACPI errors on the Lenovo
> > > > > > X201i:
> > > > > >
> > > > > > ACPI BIOS Error (bug): Could not resolve [_SB.EC.HKEY],
> > > >
> > > > AE_NOT_FOUND
> > > > > > (20180313/dswload2-160)
> > > > > > ACPI Error: AE_NOT_FOUND, During name lookup/catalog
> > > > > > (20180313/psobject-221)
> > > > > > ACPI Error: Ignore error and continue table load
> > > > > > (20180313/psobject-604)
> > > > > > ACPI Error: Skipping Scope block (20180313/psloop-532)
> > > > > >
> > > > > > and
> > > > > >
> > > > > > ACPI BIOS Error (bug): Could not resolve
> > > > > > [_SB.PCI0.LPCB.EC.HKEY.GBDC.HBDC], AE_NOT_FOUND
> > > >
> > > > (20180313/psargs-330)
> > > > > > ACPI Error: Method parse/execution failed
> > > >
> > > > _SB.PCI0.LPCB.EC.HKEY.GBDC,
> > > > > > AE_NOT_FOUND (20180313/psparse-516)
> > > > > >
> > > > > > Do you have any idea on how to fix these issues?
> > > > > >
> > > > > > Cheers,
> > > > > > Matthias