[PATCH]some more kconfig

[Patrick Georgi]

Hi,

attached patch cleans up amd/dbm690t and kontron/986lcd-m some more (not
fully). It also fixes the kconfig build for HAVE_ACPI_RESUME.

Signed-off-by: Patrick Georgi

[ron minnich]

Acked-by: Ronald G. Minnich

[Peter Stuge]

Patrick Georgi wrote:
> +++ src/mainboard/kontron/986lcd-m/Kconfig	(working copy)
> @@ -6,15 +6,22 @@
>    select NORTHBRIDGE_INTEL_I945
>    select SOUTHBRIDGE_INTEL_I82801GX
>    select SUPERIO_WINBOND_W83627THG
> select HAVE_PIRQ_TABLE
> select HAVE_MP_TABLE
> select GENERATE_ACPI_TABLES
> select GENERATE_PIRQ_TABLE
> select GENERATE_MP_TABLE

Hmm? Shouldn't GENERATE_ be set by the user.. ?

//Peter

[Stefan Reinauer]

On 12/18/09 5:56 PM, Peter Stuge wrote:
> Patrick Georgi wrote:
> > +++ src/mainboard/kontron/986lcd-m/Kconfig	(working copy)
> > @@ -6,15 +6,22 @@
> >    select NORTHBRIDGE_INTEL_I945
> >    select SOUTHBRIDGE_INTEL_I82801GX
> >    select SUPERIO_WINBOND_W83627THG
> > select HAVE_PIRQ_TABLE
> > select HAVE_MP_TABLE
> > select GENERATE_ACPI_TABLES
> > select GENERATE_PIRQ_TABLE
> > select GENERATE_MP_TABLE
>
> Hmm? Shouldn't GENERATE_ be set by the user.. ?

The user should never have to worry about that stuff.
We should not expect the user to manually enable ACPI and PIRQ before he
has a chance to get a bootable system with coreboot.

Stefan

[Myles Watson]

On Fri, Dec 18, 2009 at 11:43 AM, Stefan Reinauer wrote:
> On 12/18/09 5:56 PM, Peter Stuge wrote:
> > Patrick Georgi wrote:
> > > +++ src/mainboard/kontron/986lcd-m/Kconfig   (working copy)
> > > @@ -6,15 +6,22 @@
> > >      select NORTHBRIDGE_INTEL_I945
> > >      select SOUTHBRIDGE_INTEL_I82801GX
> > >      select SUPERIO_WINBOND_W83627THG
> > > select HAVE_PIRQ_TABLE
> > > select HAVE_MP_TABLE
> > > select GENERATE_ACPI_TABLES
> > > select GENERATE_PIRQ_TABLE
> > > select GENERATE_MP_TABLE
> >
> > Hmm? Shouldn't GENERATE_ be set by the user.. ?
>
> The user should never have to worry about that stuff.
> We should not expect the user to manually enable ACPI and PIRQ before he
> has a chance to get a bootable system with coreboot.

As long as the user doesn't touch it, GENERATE_ was set by default as long
as the board has HAVE_* set.  What this patch did was make it so that the
user can't build without ACPI tables.  I don't think that is what's wanted.
Now to remove the MP_TABLE, the user would have to edit the Kconfig file.

Thanks,
Myles

[Patrick Georgi]

Am 18.12.2009 19:50, schrieb Myles Watson:
> As long as the user doesn't touch it, GENERATE_ was set by default as
> long as the board has HAVE_* set.  What this patch did was make it so
> that the user can't build without ACPI tables.  I don't think that is
> what's wanted.  Now to remove the MP_TABLE, the user would have to
> edit the Kconfig file.

What's the right approach to them now? I somewhat missed the
introduction of GENERATE and thus its rules, and just went with what
gave me a pretty result in compareboard.

Patrick

[Myles Watson]

> Am 18.12.2009 19:50, schrieb Myles Watson:
> > As long as the user doesn't touch it, GENERATE_ was set by default as
> > long as the board has HAVE_* set.  What this patch did was make it so
> > that the user can't build without ACPI tables.  I don't think that is
> > what's wanted.  Now to remove the MP_TABLE, the user would have to
> > edit the Kconfig file.
>
> What's the right approach to them now? I somewhat missed the
> introduction of GENERATE and thus its rules, and just went with what
> gave me a pretty result in compareboard.

All the HAVE_* were supposed to be the same as newconfig, and the GENERATE_*
were supposed to default to the same as HAVE_*, but be ignored by the
comparison script, since they are not in newconfig.

Thanks,
Myles