[RFC] change the ROM caching for AMD CAR

[Rudolf Marek]

Hi all,

It looks like we can cache now the whole ROM while in CAR (i showed that in the 
analysis posted earlier, it works too ;)

The attached patch does that. Comments?

Marc and I thinks we can add some safeguard to check if any L2 data was evicted 
during CAR to RAM. This is just few instructions to enable the PerfCounter and
then  read it in the post_cache_as_ram. I will post this as separate patch.

Signed-off-by: Rudolf Marek

I did not test this particular patch however it does work with similar changes 
already. I take this patch as think for RFC, if it is enough to change it like this.

Thanks,
Rudolf

[Stefan Reinauer]

On 5/23/10 11:38 AM, Rudolf Marek wrote:
> Hi all,
>
> It looks like we can cache now the whole ROM while in CAR (i showed
> that in the analysis posted earlier, it works too ;)
>
> The attached patch does that. Comments?
>
> Marc and I thinks we can add some safeguard to check if any L2 data
> was evicted during CAR to RAM. This is just few instructions to enable
> the PerfCounter and
> then  read it in the post_cache_as_ram. I will post this as separate
> patch.
>
> Signed-off-by: Rudolf Marek
>
> I did not test this particular patch however it does work with similar
> changes already. I take this patch as think for RFC, if it is enough
> to change it like this.

Does this fix the slowness of copying coreboot_ram to ram?

Stefan

[Marc Jones]

On Sun, May 23, 2010 at 4:05 AM, Stefan Reinauer
 wrote:
> On 5/23/10 11:38 AM, Rudolf Marek wrote:
> > Hi all,
> >
> > It looks like we can cache now the whole ROM while in CAR (i showed
> > that in the analysis posted earlier, it works too ;)
> >
> > The attached patch does that. Comments?
> >
> > Marc and I thinks we can add some safeguard to check if any L2 data
> > was evicted during CAR to RAM. This is just few instructions to enable
> > the PerfCounter and
> > then  read it in the post_cache_as_ram. I will post this as separate
> > patch.
> >
> > Signed-off-by: Rudolf Marek
> >
> > I did not test this particular patch however it does work with similar
> > changes already. I take this patch as think for RFC, if it is enough
> > to change it like this.
>
> Does this fix the slowness of copying coreboot_ram to ram?

I don't expect this to fix the slow lzma decomress. The disable_car
code still changes the MTRR settings. That needs to be sorted as well.

Marc

[Marc Jones]

2010/5/23 Rudolf Marek :
> Hi all,
>
> It looks like we can cache now the whole ROM while in CAR (i showed that in
> the analysis posted earlier, it works too ;)
>
> The attached patch does that. Comments?
>
> Marc and I thinks we can add some safeguard to check if any L2 data was
> evicted during CAR to RAM. This is just few instructions to enable the
> PerfCounter and
> then  read it in the post_cache_as_ram. I will post this as separate patch.
>
> Signed-off-by: Rudolf Marek
>
> I did not test this particular patch however it does work with similar
> changes already. I take this patch as think for RFC, if it is enough to
> change it like this.

Rudolf,

I would test and ack a patch with the perfcounter setup in it.

Marc