[LinuxBIOS] [PATCH] License header fixes in src/cpu/amd/model_fxx/processor_name.c

[Uwe Hermann]

See patch, small fixes in the license header. I'm assuming GPLv2-or-later
as the file didn't explicitly mention any license version. Please let me
know if you prefer GPLv2 here.

Also, I'm assuming Sven is the copytight owner of the changes (not the
university). Please let me know whether that's correct.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

[Stefan Reinauer]

* Uwe Hermann <[e-mail]> [070526 16:10]:
> See patch, small fixes in the license header. I'm assuming GPLv2-or-later
> as the file didn't explicitly mention any license version. Please let me
> know if you prefer GPLv2 here.

Please assume GPLv2 for all files I wrote.
> + * Copyright (C) 2006 coresystems GmbH
> + * (Written by Stefan Reinauer <[e-mail]> for coresystems GmbH)
> - * (C) 2006 by coresystems GmbH <[e-mail]>
> - *

...


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: [phone] • Fax: [phone]
Email: [e-mail]  • http://www.coresystems.de/

[Uwe Hermann]

On Sat, May 26, 2007 at 05:23:42PM +0200, Stefan Reinauer wrote:
> * Uwe Hermann <[e-mail]> [070526 16:10]:
> > See patch, small fixes in the license header. I'm assuming GPLv2-or-later
> > as the file didn't explicitly mention any license version. Please let me
> > know if you prefer GPLv2 here.
>
> Please assume GPLv2 for all files I wrote.

OK, updated patch attached.
> > + * Copyright (C) 2006 coresystems GmbH
> > + * (Written by Stefan Reinauer <[e-mail]> for coresystems GmbH)
> > - * (C) 2006 by coresystems GmbH <[e-mail]>
> > - *
>
> ...

Is this incorrect? I assumed all coresystems GmbH code is written by you?
(other than that I just moved the (C) line up into the license header)


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

[Stefan Reinauer]

* Uwe Hermann <[e-mail]> [070526 18:48]:
> > > + * Copyright (C) 2006 coresystems GmbH
> > > + * (Written by Stefan Reinauer <[e-mail]> for coresystems GmbH)
> > > - * (C) 2006 by coresystems GmbH <[e-mail]>
> > > - *
> >
> > ...
>
> Is this incorrect? I assumed all coresystems GmbH code is written by you?
> (other than that I just moved the (C) line up into the license header)

In this case it is true, but there might / will come contributions from
other coresystems employees some time. (hopefully ;-)
> Use the common LinuxBIOS license header format.
>
> Signed-off-by: Uwe Hermann <[e-mail]>

Acked-by: Stefan Reinauer <[e-mail]>
> Index: src/cpu/amd/model_fxx/processor_name.c
> ===================================================================
> --- src/cpu/amd/model_fxx/processor_name.c	(Revision 2699)
> +++ src/cpu/amd/model_fxx/processor_name.c	(Arbeitskopie)
> @@ -1,26 +1,37 @@
>  /*
> - * processor_name.c
> + * This file is part of the LinuxBIOS project.
>   *
> + * Copyright (C) 2006 coresystems GmbH
> + * (Written by Stefan Reinauer <[e-mail]> for coresystems GmbH)
> + * Copyright (C) 2007 Sven Kapferer <[e-mail]>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2 of the License.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA, 02110-1301 USA
> + */
> +
> +/*
>   * This code sets the Processor Name String for AMD64 CPUs.
>   *
>   * Written by Stefan Reinauer <[e-mail]> using
>   * the Revision Guide for AMD Athlon™ 64 and AMD Opteron™ Processors
> - * Document ID 25759 Rev 3.59, April 2006 (Public Version)
> + * Document ID 25759 Rev 3.59, April 2006 (Public Version).
>   *
> - * (C) 2006 by coresystems GmbH <[e-mail]>
> - *
>   * Updated by Sven Kapferer <[e-mail]> using
>   * the Revision Guide for AMD NPT Family 0Fh Processors
> - * Document ID 33610 Rev 3.00, October 2006 (Public Version)
> - *
> - * This file is subject to the terms and conditions of the GNU General
> - * Public License. See the file COPYING in the main directory of this
> - * archive for more details.
> - *
> + * Document ID 33610 Rev 3.00, October 2006 (Public Version).
>   */
>
> #include <console/console.h>
> -
>  #include <string.h>
>  #include <cpu/x86/msr.h>

[LinuxBIOS] [PATCH] License header fixes in src/cpu/amd/model_fxx/processor_name.c

[Sven Kapferer]

Uwe Hermann wrote:
> Also, I'm assuming Sven is the copytight owner of the changes (not the
> university). Please let me know whether that's correct.

In my case it is not. I am an employee and not a student, therefore the 
copyright owner is the university. Please change the copyright string 
accordingly.

Regards,
- Sven

-- 
Sven Kapferer
University of Mannheim - Computer Architecture Group
Address : B6 26, 68131 Mannheim, Germany
Web     : http://ra.ti.uni-mannheim.de
Email   : [e-mail]
Phone   : [phone]   Fax: [phone]

[LinuxBIOS] [PATCH] License header fixes in src/cpu/amd/model_fxx/processor_name.c

[Uwe Hermann]

On Tue, May 29, 2007 at 01:17:29PM +0200, Sven Kapferer wrote:
> Uwe Hermann wrote:
> > Also, I'm assuming Sven is the copytight owner of the changes (not the
> > university). Please let me know whether that's correct.
>
> In my case it is not. I am an employee and not a student, therefore the 
> copyright owner is the university. Please change the copyright string 
> accordingly.

Done, thanks. New patch attached.

Please send an Acked-by if it looks ok now.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

[LinuxBIOS] [PATCH] License header fixes in src/cpu/amd/model_fxx/processor_name.c

[Sven Kapferer]

Uwe Hermann wrote:
> On Tue, May 29, 2007 at 01:17:29PM +0200, Sven Kapferer wrote:
> > Uwe Hermann wrote:
> > > Also, I'm assuming Sven is the copytight owner of the changes (not the
> > > university). Please let me know whether that's correct.
> > > In my case it is not. I am an employee and not a student, therefore the 
> > > copyright owner is the university. Please change the copyright string 
> > > accordingly.
>
> Done, thanks. New patch attached.
>
> Please send an Acked-by if it looks ok now.

Acked-by: Sven Kapferer <[e-mail]>


-- 
Sven Kapferer
University of Mannheim - Computer Architecture Group
Address : B6 26, 68131 Mannheim, Germany
Web     : http://ra.ti.uni-mannheim.de
Email   : [e-mail]
Phone   : [phone]   Fax: [phone]

[LinuxBIOS] [PATCH] License header fixes in src/cpu/amd/model_fxx/processor_name.c

[Uwe Hermann]

On Tue, May 29, 2007 at 01:49:56PM +0200, Sven Kapferer wrote:
> Acked-by: Sven Kapferer <[e-mail]>

Thanks, r2704.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org