Patch not signed off since I haven't tested this at all.
I would appreciate test results from using this patch on boards which have both SATA controller(s) and one or more PATA controllers in compatibility (AKA legacy) mode.
Previously it was not possible to boot from a drive on a PATA controller in compat mode when there were PCI devices in native mode (SATA always are) on lower devfn numbers. Native mode devices were basically still assumed to use the legacy IO ports in the code looking up IO ports for compat devices.
Please set DEBUG_IDE=1 in Config and send output to me or the list.
Thanks!
//Peter
On Sat, Jun 21, 2008 at 04:41:28AM +0200, Peter Stuge wrote:
Patch not signed off since I haven't tested this at all.
Found a bug in the debug() calls. Fixed in the attached version.
//Peter
Peter Stuge wrote:
On Sat, Jun 21, 2008 at 04:41:28AM +0200, Peter Stuge wrote:
Patch not signed off since I haven't tested this at all.
Found a bug in the debug() calls. Fixed in the attached version.
//Peter
It works!
Pre-Acked Bari Ari bari@onelabs.com
On Fri, Jun 20, 2008 at 11:55:54PM -0500, bari wrote:
Peter Stuge wrote:
Found a bug in the debug() calls. Fixed in the attached version.
It works!
Great! I'm looking forward to more test results. Here's a properly signed-off patch with some small debug message fixes and better explanation.
Anyone else who has a board with a SATA PCI device before the PATA/IDE device, please test booting from PATA using this patch.
It would also be interesting to boot this patch on a board with only PATA/IDE devices - ie. no SATA or native mode PATA.
//Peter
Peter Stuge wrote:
On Fri, Jun 20, 2008 at 11:55:54PM -0500, bari wrote:
Peter Stuge wrote:
Found a bug in the debug() calls. Fixed in the attached version.
It works!
Great! I'm looking forward to more test results. Here's a properly signed-off patch with some small debug message fixes and better explanation.
Anyone else who has a board with a SATA PCI device before the PATA/IDE device, please test booting from PATA using this patch.
It would also be interesting to boot this patch on a board with only PATA/IDE devices - ie. no SATA or native mode PATA.
//Peter
Seems to be fine on any combination with the vt8237r.
Post-acked or is it acked-again?
Acked: Bari Ari bari@onelabs.com
On Sat, Jun 21, 2008 at 08:06:50AM +0200, Peter Stuge wrote:
On Fri, Jun 20, 2008 at 11:55:54PM -0500, bari wrote:
Peter Stuge wrote:
Found a bug in the debug() calls. Fixed in the attached version.
It works!
Great! I'm looking forward to more test results. Here's a properly signed-off patch with some small debug message fixes and better explanation.
Anyone else who has a board with a SATA PCI device before the PATA/IDE device, please test booting from PATA using this patch.
It would also be interesting to boot this patch on a board with only PATA/IDE devices - ie. no SATA or native mode PATA.
I can confirm that my epia-m continues to boot with a patched filo. The epia-m has only PATA, and it is in compatibility mode.
-Kevin
Anyone want to try with an IDE controller in native mode? I know vt8237r can handle it, shouldn't this make it so FILO can figure it out?
-Corey
On Sat, Jun 21, 2008 at 8:17 PM, Kevin O'Connor kevin@koconnor.net wrote:
On Sat, Jun 21, 2008 at 08:06:50AM +0200, Peter Stuge wrote:
On Fri, Jun 20, 2008 at 11:55:54PM -0500, bari wrote:
Peter Stuge wrote:
Found a bug in the debug() calls. Fixed in the attached version.
It works!
Great! I'm looking forward to more test results. Here's a properly signed-off patch with some small debug message fixes and better explanation.
Anyone else who has a board with a SATA PCI device before the PATA/IDE device, please test booting from PATA using this patch.
It would also be interesting to boot this patch on a board with only PATA/IDE devices - ie. no SATA or native mode PATA.
I can confirm that my epia-m continues to boot with a patched filo. The epia-m has only PATA, and it is in compatibility mode.
-Kevin
-- coreboot mailing list coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On Sat, Jun 21, 2008 at 09:54:34PM -0400, Corey Osgood wrote:
Anyone want to try with an IDE controller in native mode? I know vt8237r can handle it, shouldn't this make it so FILO can figure it out?
Please do test more if you can! I committed this just a second ago but would love to see test reports from more complex setups.
If the IDE controller is in native mode, please try booting from more than just the first drive, to exercise the new code.
//Peter
bari will probably beat me to it ;) I've still got my cn700/vt8237r board all set up on the test station, I just haven't had time to even think about touching it in, well, a long time. Lately my attention's been turned to race cars :D But as soon as those are up, running, and out of the garage, I've got a few things pending for cn700.
-Corey
On Sat, Jun 21, 2008 at 9:56 PM, Peter Stuge peter@stuge.se wrote:
On Sat, Jun 21, 2008 at 09:54:34PM -0400, Corey Osgood wrote:
Anyone want to try with an IDE controller in native mode? I know vt8237r can handle it, shouldn't this make it so FILO can figure it out?
Please do test more if you can! I committed this just a second ago but would love to see test reports from more complex setups.
If the IDE controller is in native mode, please try booting from more than just the first drive, to exercise the new code.
//Peter
-- coreboot mailing list coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On Sat, Jun 21, 2008 at 02:24:16PM -0500, bari wrote:
Seems to be fine on any combination with the vt8237r.
Post-acked or is it acked-again?
Acked: Bari Ari bari@onelabs.com
On Sat, Jun 21, 2008 at 08:17:10PM -0400, Kevin O'Connor wrote:
I can confirm that my epia-m continues to boot with a patched filo. The epia-m has only PATA, and it is in compatibility mode.
Thanks for testing this! I confirmed correct functionality also on ALIX 3c3.
FILO r49
//Peter
On 22/06/08 03:55 +0200, Peter Stuge wrote:
On Sat, Jun 21, 2008 at 02:24:16PM -0500, bari wrote:
Seems to be fine on any combination with the vt8237r.
Post-acked or is it acked-again?
Acked: Bari Ari bari@onelabs.com
On Sat, Jun 21, 2008 at 08:17:10PM -0400, Kevin O'Connor wrote:
I can confirm that my epia-m continues to boot with a patched filo. The epia-m has only PATA, and it is in compatibility mode.
Thanks for testing this! I confirmed correct functionality also on ALIX 3c3.
FILO r49
Is it still too early to bump buildrom to the new revision?
Jordan
On Mon, Jun 23, 2008 at 09:16:00AM -0600, Jordan Crouse wrote:
Thanks for testing this! I confirmed correct functionality also on ALIX 3c3.
FILO r49
Is it still too early to bump buildrom to the new revision?
Go ahead. If there's a problem we can fix it.
The patch is only relevant with SATA PCI devices before PATA PCI devices when one wants to boot from PATA.
//Peter
On 23/06/08 17:18 +0200, Peter Stuge wrote:
On Mon, Jun 23, 2008 at 09:16:00AM -0600, Jordan Crouse wrote:
Thanks for testing this! I confirmed correct functionality also on ALIX 3c3.
FILO r49
Is it still too early to bump buildrom to the new revision?
Go ahead. If there's a problem we can fix it.
The patch is only relevant with SATA PCI devices before PATA PCI devices when one wants to boot from PATA.
Which is pretty much every motherboard made after 2006.. :)
r207 to buildrom. Good luck.
Jordan
//Peter
-- coreboot mailing list coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On Mon, Jun 23, 2008 at 09:29:30AM -0600, Jordan Crouse wrote:
The patch is only relevant with SATA PCI devices before PATA PCI devices when one wants to boot from PATA.
Which is pretty much every motherboard made after 2006.. :)
m57sli has PATA first, but anyway I guess not too many are booting from PATA these days.
r207 to buildrom. Good luck.
\o/
//Peter
Jordan Crouse wrote:
On 22/06/08 03:55 +0200, Peter Stuge wrote:
On Sat, Jun 21, 2008 at 02:24:16PM -0500, bari wrote:
Seems to be fine on any combination with the vt8237r.
Post-acked or is it acked-again?
Acked: Bari Ari bari@onelabs.com
On Sat, Jun 21, 2008 at 08:17:10PM -0400, Kevin O'Connor wrote:
I can confirm that my epia-m continues to boot with a patched filo. The epia-m has only PATA, and it is in compatibility mode.
Thanks for testing this! I confirmed correct functionality also on ALIX 3c3.
FILO r49
Is it still too early to bump buildrom to the new revision?
Jordan
Fine by me, it hasn't given me any problems yet with any combination of drives and their boot orders. Buildrom needs some updating.
-Bari
On 22.06.2008 03:55, Peter Stuge wrote:
Thanks for testing this! I confirmed correct functionality also on ALIX 3c3.
2c3 or 3c3?
Regards, Carl-Daniel
On Mon, Jun 23, 2008 at 08:29:03PM +0200, Carl-Daniel Hailfinger wrote:
On 22.06.2008 03:55, Peter Stuge wrote:
Thanks for testing this! I confirmed correct functionality also on ALIX 3c3.
2c3 or 3c3?
3c3, I don't have a 2c3. I think that's Ward's board.
//Peter
On 23.06.2008 22:42, Peter Stuge wrote:
On Mon, Jun 23, 2008 at 08:29:03PM +0200, Carl-Daniel Hailfinger wrote:
On 22.06.2008 03:55, Peter Stuge wrote:
Thanks for testing this! I confirmed correct functionality also on ALIX 3c3.
2c3 or 3c3?
3c3, I don't have a 2c3. I think that's Ward's board.
Great! So we support another one of the alix boards and nobody except knew about it... Could you please add a notice to the wiki and/or v3 Kconfig?
Regards, Carl-Daniel
On Mon, Jun 23, 2008 at 11:54:22PM +0200, Carl-Daniel Hailfinger wrote:
Thanks for testing this! I confirmed correct functionality also on ALIX 3c3.
2c3 or 3c3?
3c3, I don't have a 2c3. I think that's Ward's board.
Great! So we support another one of the alix boards and nobody except knew about it... Could you please add a notice to the wiki and/or v3 Kconfig?
Not so fast. I was refering to the FILO patch. :)
coreboot did boot the board, but interrupts seem not OK yet.
I'll look into that though. :)
//Peter
-
bari -
Carl-Daniel Hailfinger -
Corey Osgood -
Jordan Crouse -
Kevin O'Connor -
Peter Stuge