[commit] r5832 - trunk/src/mainboard/hp/dl165_g6_fam10

[repository service]

Author: oxygene
Date: Fri Sep 24 20:12:46 2010
New Revision: 5832
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5832

Log:
Fix hp/dl165_g6_fam10 build. Failed to take r5800 and
another recent change into account.

Signed-off-by: Patrick Georgi 
Acked-by: Patrick Georgi

Modified:
   trunk/src/mainboard/hp/dl165_g6_fam10/Kconfig
   trunk/src/mainboard/hp/dl165_g6_fam10/romstage.c

Modified: trunk/src/mainboard/hp/dl165_g6_fam10/Kconfig
==============================================================================
--- trunk/src/mainboard/hp/dl165_g6_fam10/Kconfig	Fri Sep 24 19:35:32 2010	(r5831)
+++ trunk/src/mainboard/hp/dl165_g6_fam10/Kconfig	Fri Sep 24 20:12:46 2010	(r5832)
@@ -9,6 +9,8 @@
    select SOUTHBRIDGE_BROADCOM_BCM21000
    select SOUTHBRIDGE_BROADCOM_BCM5785
    select SUPERIO_NSC_PC87417
+	select DIMM_DDR2
+	select DIMM_REGISTERED
    select HAVE_OPTION_TABLE
    select HAVE_BUS_CONFIG
    select HAVE_PIRQ_TABLE

Modified: trunk/src/mainboard/hp/dl165_g6_fam10/romstage.c
==============================================================================
--- trunk/src/mainboard/hp/dl165_g6_fam10/romstage.c	Fri Sep 24 19:35:32 2010	(r5831)
+++ trunk/src/mainboard/hp/dl165_g6_fam10/romstage.c	Fri Sep 24 20:12:46 2010	(r5832)
@@ -54,6 +54,7 @@
 #include "lib/ramtest.c"
 #include <cpu/amd/model_10xxx_rev.h>
 #include "southbridge/broadcom/bcm5785/bcm5785_early_smbus.c"
+#include "southbridge/broadcom/bcm5785/bcm5785_enable_rom.c"
 #include "northbridge/amd/amdfam10/raminit.h"
 #include "northbridge/amd/amdfam10/amdfam10.h"

[commit] r5832 - trunk/src/mainboard/hp/dl165_g6_fam10

[Myles Watson]

> Modified: trunk/src/mainboard/hp/dl165_g6_fam10/Kconfig
>
> --- trunk/src/mainboard/hp/dl165_g6_fam10/Kconfig       Fri Sep 24 19:35:32 2010        (r5831)
> +++ trunk/src/mainboard/hp/dl165_g6_fam10/Kconfig       Fri Sep 24 20:12:46 2010        (r5832)
> @@ -9,6 +9,8 @@
>        select SOUTHBRIDGE_BROADCOM_BCM21000
>        select SOUTHBRIDGE_BROADCOM_BCM5785
>        select SUPERIO_NSC_PC87417
> select DIMM_DDR2
> select DIMM_REGISTERED

This fixed the build for me.
> Modified: trunk/src/mainboard/hp/dl165_g6_fam10/romstage.c
>
> --- trunk/src/mainboard/hp/dl165_g6_fam10/romstage.c    Fri Sep 24 19:35:32 2010        (r5831)
> +++ trunk/src/mainboard/hp/dl165_g6_fam10/romstage.c    Fri Sep 24 20:12:46 2010        (r5832)
> @@ -54,6 +54,7 @@
>  #include "lib/ramtest.c"
>  #include <cpu/amd/model_10xxx_rev.h>
>  #include "southbridge/broadcom/bcm5785/bcm5785_early_smbus.c"
> +#include "southbridge/broadcom/bcm5785/bcm5785_enable_rom.c"

This broke it again.

Thanks,
Myles

[commit] r5832 - trunk/src/mainboard/hp/dl165_g6_fam10

[Patrick Georgi]

Am 24.09.2010 20:19, schrieb Myles Watson:
> > +#include "southbridge/broadcom/bcm5785/bcm5785_enable_rom.c"
>
> This broke it again.

That was an issue I had in my local tree - with local changes to the
southbridge that I wasn't aware of anymore. Fixed in r5834.

Thanks,
Patrick