Re: [coreboot] [v2] r4611 - in trunk/coreboot-v2/src: cpu/amd/model_gx2 northbridge/amd/gx2 southbridge/amd/cs5536

[Stefan Reinauer]

On 8/28/09 4:47 PM, [e-mail] wrote:
> case 0xBEA7:
> *eax=33;
> break;
> case 0xBEA4:
> *eax=333;
> break;

What about these int15 callbacks? I've seen from logs that the VSA code
calls these interrupts. Are they not needed?

Stefan

[v2] r4611 - in trunk/coreboot-v2/src: cpu/amd/model_gx2 northbridge/amd/gx2 southbridge/amd/cs5536

[ron minnich]

On Fri, Aug 28, 2009 at 8:27 AM, Stefan Reinauer wrote:
> What about these int15 callbacks? I've seen from logs that the VSA code
> calls these interrupts. Are they not needed?

I'm not sure they are. I looked at v3 and could not find the
conversation but IIRC VSA just does it's job and does not do
callbacks. V3 does not appear to load the idt when doing vsmsetup. But
my memory may be wrong.

ron

[v2] r4611 - in trunk/coreboot-v2/src: cpu/amd/model_gx2 northbridge/amd/gx2 southbridge/amd/cs5536

[Marc Jones]

On Fri, Aug 28, 2009 at 9:29 AM, ron minnich wrote:
> On Fri, Aug 28, 2009 at 8:27 AM, Stefan Reinauer wrote:
> > What about these int15 callbacks? I've seen from logs that the VSA code
> > calls these interrupts. Are they not needed?
>
> I'm not sure they are. I looked at v3 and could not find the
> conversation but IIRC VSA just does it's job and does not do
> callbacks. V3 does not appear to load the idt when doing vsmsetup. But
> my memory may be wrong.

It had them when it was originally ported but I removed those
callbacks in one of the iterations of VSA a while ago.

Marc

[v2] r4611 - in trunk/coreboot-v2/src: cpu/amd/model_gx2 northbridge/amd/gx2 southbridge/amd/cs5536

[Stefan Reinauer]

On 8/28/09 5:40 PM, Marc Jones wrote:
> On Fri, Aug 28, 2009 at 9:29 AM, ron minnich wrote:
> > On Fri, Aug 28, 2009 at 8:27 AM, Stefan Reinauer wrote:
> > > What about these int15 callbacks? I've seen from logs that the VSA code
> > > calls these interrupts. Are they not needed?
> >
> > I'm not sure they are. I looked at v3 and could not find the
> > conversation but IIRC VSA just does it's job and does not do
> > callbacks. V3 does not appear to load the idt when doing vsmsetup. But
> > my memory may be wrong.
>
> It had them when it was originally ported but I removed those
> callbacks in one of the iterations of VSA a while ago.

Ah wonderful!