Re: [coreboot] r3391 - in trunk/coreboot-v2: src/mainboard/a-trend src/mainboard/a-trend/atc-6240 targets/a-trend targets/a-trend/atc-6240

[Stefan Reinauer]

Uwe,

please also add a Config-abuild.lb for this mainboard. Without, the 
resulting image will have no mainboard name set.

(BTW, why don't you set the mainboard name in the mainboard's options.lb 
to begin with?)

[e-mail] wrote:
> Added: trunk/coreboot-v2/targets/a-trend/atc-6240/Config.lb
>
> --- trunk/coreboot-v2/targets/a-trend/atc-6240/Config.lb	                        (rev 0)
> +++ trunk/coreboot-v2/targets/a-trend/atc-6240/Config.lb	2008-06-26 19:42:25 UTC (rev 3391)
> @@ -0,0 +1,49 @@
> +##
> +## This file is part of the coreboot project.
> +##
> +## Copyright (C) 2008 Uwe Hermann 
> +##
> +## This program is free software; you can redistribute it and/or modify
> +## it under the terms of the GNU General Public License as published by
> +## the Free Software Foundation; either version 2 of the License, or
> +## (at your option) any later version.
> +##
> +## This program is distributed in the hope that it will be useful,
> +## but WITHOUT ANY WARRANTY; without even the implied warranty of
> +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +## GNU General Public License for more details.
> +##
> +## You should have received a copy of the GNU General Public License
> +## along with this program; if not, write to the Free Software
> +## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> +##
>
> +target atc-6240
> +mainboard a-trend/atc-6240
>
> +option ROM_SIZE = 256 * 1024
>
> +option MAINBOARD_VENDOR = "A-Trend"
> +option MAINBOARD_PART_NUMBER = "ATC-6240"
>
> +option IRQ_SLOT_COUNT = 7
>
> +option DEFAULT_CONSOLE_LOGLEVEL = 9
> +option MAXIMUM_CONSOLE_LOGLEVEL = 9
>
> +option CONFIG_CONSOLE_VGA = 1
> +option CONFIG_PCI_ROM_RUN = 1
>
> +romimage "normal"
> option USE_FALLBACK_IMAGE = 0
> option COREBOOT_EXTRA_VERSION = ".0Normal"
> payload ../payload.elf
>
> +end
>
> +romimage "fallback"
> option USE_FALLBACK_IMAGE = 1
> option COREBOOT_EXTRA_VERSION = ".0Fallback"
> payload ../payload.elf
>
> +end
>
> +buildrom ./coreboot.rom ROM_SIZE "normal" "fallback"

r3391 - in trunk/coreboot-v2: src/mainboard/a-trend src/mainboard/a-trend/atc-6240 targets/a-trend targets/a-trend/atc-6240

[Uwe Hermann]

Hi,

On Thu, Jun 26, 2008 at 10:24:17PM +0200, Stefan Reinauer wrote:
> please also add a Config-abuild.lb for this mainboard. Without, the  
> resulting image will have no mainboard name set.

You mean the MAINBOARD_VENDOR / MAINBOARD_PART_NUMBER variables?
> (BTW, why don't you set the mainboard name in the mainboard's options.lb  
> to begin with?)

Just a minor quirk, I like the Options.lb to be as generic as possible
and stuff the board-specific options into targets/.../Config.lb as
overrides. You'll notice that all the 1-2 dozen 440BX boards have an
identical or almost-identical Options.lb, the specific variables all
being in targets/.../Config.lb.

Earlier I was planning to unify the Options.lb for them one day, adding one
copy $somewhere, and using a symlink for the other ones, but that's probably
not going to happen anymore, and I don't care enough about it anymore
either, I guess.

Would moving MAINBOARD_VENDOR / MAINBOARD_PART_NUMBER to Options.lb fix
the problem with abuild?

Uwe.

r3391 - in trunk/coreboot-v2: src/mainboard/a-trend src/mainboard/a-trend/atc-6240 targets/a-trend targets/a-trend/atc-6240

[Stefan Reinauer]

* Uwe Hermann  [080627 00:03]:
> On Thu, Jun 26, 2008 at 10:24:17PM +0200, Stefan Reinauer wrote:
> > please also add a Config-abuild.lb for this mainboard. Without, the  
> > resulting image will have no mainboard name set.
>
> You mean the MAINBOARD_VENDOR / MAINBOARD_PART_NUMBER variables?

yes.
> Would moving MAINBOARD_VENDOR / MAINBOARD_PART_NUMBER to Options.lb fix
> the problem with abuild?

I don't mind leaving it where it is, if that's closer to your
unification approach. It just needs to get set for abuild, too. That
could be in mainboard Options.lb or in a custom Config-abuild.lb

Stefan