Hi,
Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.
1 new defect(s) introduced to coreboot found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s)
** CID 1383864: (UNUSED_VALUE) /src/northbridge/intel/x4x/raminit_ddr2.c: 1205 in dradrb_ddr2() /src/northbridge/intel/x4x/raminit_ddr2.c: 1203 in dradrb_ddr2()
________________________________________________________________________________________________________ *** CID 1383864: (UNUSED_VALUE) /src/northbridge/intel/x4x/raminit_ddr2.c: 1205 in dradrb_ddr2() 1199 // DRB 1200 FOR_EACH_POPULATED_RANK(s->dimms, ch, r) { 1201 if (s->dimms[ch<<1].card_type != RAW_CARD_UNPOPULATED 1202 && (r) < s->dimms[ch<<1].ranks) 1203 i = ch << 1; 1204 else
CID 1383864: (UNUSED_VALUE) Assigning value from "(ch << 1) + 1" to "i" here, but that stored value is overwritten before it can be used.
1205 i = (ch << 1) + 1; 1206 if (ch == 0) { 1207 dra0 = (c0dra >> (8*r)) & 0x7f; 1208 c0drb = (u16)(c0drb + drbtab[dra0]); 1209 MCHBAR16(0x200 + 2*r) = c0drb; 1210 } else { /src/northbridge/intel/x4x/raminit_ddr2.c: 1203 in dradrb_ddr2() 1197 MCHBAR8(0x660) = MCHBAR8(0x660) | 1; 1198 1199 // DRB 1200 FOR_EACH_POPULATED_RANK(s->dimms, ch, r) { 1201 if (s->dimms[ch<<1].card_type != RAW_CARD_UNPOPULATED 1202 && (r) < s->dimms[ch<<1].ranks)
CID 1383864: (UNUSED_VALUE) Assigning value from "ch << 1" to "i" here, but that stored value is overwritten before it can be used.
1203 i = ch << 1; 1204 else 1205 i = (ch << 1) + 1; 1206 if (ch == 0) { 1207 dra0 = (c0dra >> (8*r)) & 0x7f; 1208 c0drb = (u16)(c0drb + drbtab[dra0]);
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...
To manage Coverity Scan email notifications for "coreboot@coreboot.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...