[v2] AMD Fam10 gart setting

[Marc Jones]

GART table walk enable set.

[Peter Stuge]

On Wed, Jul 16, 2008 at 04:00:09PM -0600, Marc Jones wrote:
> Add Fam10 Gart table walk enable recomended by the BKDG.
>
> Signed-off-by: Marc Jones

Acked-by: Peter Stuge
> Index: coreboot-v2/src/cpu/amd/model_10xxx/defaults.h
>
> --- coreboot-v2.orig/src/cpu/amd/model_10xxx/defaults.h	2008-04-23 17:08:42.000000000 -0600
> +++ coreboot-v2/src/cpu/amd/model_10xxx/defaults.h	2008-04-23 17:10:19.000000000 -0600
> @@ -46,6 +46,10 @@
>      0xF << 19, 0x00000000,
>      0xF << 19, 0x00000000 },	/* [RtryHt[0..3]]=1 */
> { MC4_CTL_MASK, AMD_DR_ALL, AMD_PTYPE_ALL,
>  0x1 << 10, 0x00000000,
>  0x1 << 10, 0x00000000 },	/* [GartTblWkEn]=1 */
> { DC_CFG, AMD_DR_ALL, AMD_PTYPE_SVR,
>    0x00000000, 0x00000004,
>    0x00000000, 0x0000000C },	/* [REQ_CTR] = 1 for Server */

[Carl-Daniel Hailfinger]

On 17.07.2008 00:00, Marc Jones wrote:
> GART table walk enable set.
>
> Add Fam10 Gart table walk enable recomended by the BKDG.
>
> Signed-off-by: Marc Jones
> Index: coreboot-v2/src/cpu/amd/model_10xxx/defaults.h
>
> --- coreboot-v2.orig/src/cpu/amd/model_10xxx/defaults.h	2008-04-23 17:08:42.000000000 -0600
> +++ coreboot-v2/src/cpu/amd/model_10xxx/defaults.h	2008-04-23 17:10:19.000000000 -0600
> @@ -46,6 +46,10 @@
>      0xF << 19, 0x00000000,
>      0xF << 19, 0x00000000 },	/* [RtryHt[0..3]]=1 */
> { MC4_CTL_MASK, AMD_DR_ALL, AMD_PTYPE_ALL,
>  0x1 << 10, 0x00000000,
>  0x1 << 10, 0x00000000 },	/* [GartTblWkEn]=1 */
> { DC_CFG, AMD_DR_ALL, AMD_PTYPE_SVR,
>    0x00000000, 0x00000004,
>    0x00000000, 0x0000000C },	/* [REQ_CTR] = 1 for Server */

My Fam 10h BKDG 31116 Rev 3.06 - March 26, 2008 does not contain that
recommendation or I'm misreading it. Can you please point to the page
where this is mentioned?
Thanks.

Regards,
Carl-Daniel

[Marc Jones]

Carl-Daniel Hailfinger wrote:
> My Fam 10h BKDG 31116 Rev 3.06 - March 26, 2008 does not contain that
> recommendation or I'm misreading it. Can you please point to the page
> where this is mentioned?
> Thanks.

Huh, You are correct. There is no recommendation in there for MCA bits. 
It thought there were.  I was matching the internal development BIOS 
setting.

I revise my comment:

Add Fam10 Gart table walk enable for MCA reporting to match AMD example 
code.

Signed-off-by: Marc Jones

[Carl-Daniel Hailfinger]

On 17.07.2008 01:48, Marc Jones wrote:
> Carl-Daniel Hailfinger wrote:
> > My Fam 10h BKDG 31116 Rev 3.06 - March 26, 2008 does not contain that
> > recommendation or I'm misreading it. Can you please point to the page
> > where this is mentioned?
> > Thanks.
>
> Huh, You are correct. There is no recommendation in there for MCA
> bits. It thought there were.  I was matching the internal development
> BIOS setting.
>
> I revise my comment:

Thanks for rechecking this.
> Add Fam10 Gart table walk enable for MCA reporting to match AMD
> example code.
>
> Signed-off-by: Marc Jones

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[Marc Jones]

Carl-Daniel Hailfinger wrote:
> On 17.07.2008 01:48, Marc Jones wrote:
> > Carl-Daniel Hailfinger wrote:
> > > My Fam 10h BKDG 31116 Rev 3.06 - March 26, 2008 does not contain that
> > > recommendation or I'm misreading it. Can you please point to the page
> > > where this is mentioned?
> > > Thanks.
> >
> > Huh, You are correct. There is no recommendation in there for MCA
> > bits. It thought there were.  I was matching the internal development
> > BIOS setting.
> >
> > I revise my comment:
>
> Thanks for rechecking this.
> > Add Fam10 Gart table walk enable for MCA reporting to match AMD
> > example code.
> >
> > Signed-off-by: Marc Jones
>
> Acked-by: Carl-Daniel Hailfinger
>
> Regards,
> Carl-Daniel

r3424