#1: ext2 won't work if FAT is enabled ------------------------------------+--------------------------------------- Reporter: hawke@hawkesnest.net | Owner: somebody Type: defect | Status: new Priority: minor | Milestone: Component: component1 | Version: Keywords: | Dependencies: Patchstatus: there is no patch | ------------------------------------+--------------------------------------- If both the FAT filesystem and the ext2 filesystem are enabled, the ext2 filesystem cannot be used because filo treats any FS as fat.
This may also apply to other filesystems when there are several enabled
#1: ext2 won't work if FAT is enabled -------------------------------------+-------------------------------------- Reporter: hawke@hawkesnest.net | Owner: somebody Type: defect | Status: new Priority: minor | Milestone: FILO 0.6 Component: FILO | Version: Resolution: | Keywords: Dependencies: | Patchstatus: there is no patch -------------------------------------+-------------------------------------- Changes (by stepan):
* milestone: => FILO 0.6
#1: ext2 won't work if FAT is enabled -------------------------------------+-------------------------------------- Reporter: hawke@hawkesnest.net | Owner: stepan Type: defect | Status: new Priority: minor | Milestone: FILO 0.6 Component: FILO | Version: Resolution: | Keywords: Dependencies: | Patchstatus: there is no patch -------------------------------------+-------------------------------------- Changes (by stepan):
* owner: somebody => stepan
Comment:
Can you provide more information on this issue please? (ie. compile FILO with debugging for VFS and the filesystems. This problem seems to be very sporadic. I could not reproduce it in any case here, but Patrick told me he had seen it before.
#1: ext2 won't work if FAT is enabled -------------------------------------+-------------------------------------- Reporter: hawke@hawkesnest.net | Owner: stepan Type: defect | Status: assigned Priority: minor | Milestone: FILO 0.6 Component: FILO | Version: Resolution: | Keywords: Dependencies: | Patchstatus: patch needs review -------------------------------------+-------------------------------------- Changes (by stepan):
* status: new => assigned * patchstatus: there is no patch => patch needs review
Comment:
I attached a potential fix for the problem.
According to Wikipedia, the type entries are mandatory in the FAT extended BPB.
Didn't test this, neither with a FAT device, now with an ext2 device. Please report any positive or negative tests.
#1: ext2 won't work if FAT is enabled -------------------------------------+-------------------------------------- Reporter: hawke@hawkesnest.net | Owner: stepan Type: defect | Status: assigned Priority: minor | Milestone: FILO 0.6 Component: FILO | Version: Resolution: | Keywords: Dependencies: | Patchstatus: patch needs review -------------------------------------+--------------------------------------
Comment(by hawke@hawkesnest.net):
It works, but has warnings: /usr/src/filo/fs/fsys_fat.c: In function 'fat_mount': /usr/src/filo/fs/fsys_fat.c:102: warning: pointer targets in passing argument 1 of 'strcmp' differ in signedness /usr/src/filo/fs/fsys_fat.c:103: warning: pointer targets in passing argument 1 of 'strcmp' differ in signedness /usr/src/filo/fs/fsys_fat.c:104: warning: pointer targets in passing argument 1 of 'strcmp' differ in signedness
#1: ext2 won't work if FAT is enabled -------------------------------------+-------------------------------------- Reporter: hawke@hawkesnest.net | Owner: stepan Type: defect | Status: assigned Priority: minor | Milestone: FILO 0.6 Component: FILO | Version: Resolution: | Keywords: Dependencies: | Patchstatus: patch needs review -------------------------------------+--------------------------------------
Comment(by oxygene):
After some talk on IRC, it was clear that the patch only solves the issue part-way: FAT isn't a "grab-all" filesystem anymore, but now it's "grab nothing".
new version of the patch with strcmp(...) replaced by strncmp(..., 5), so the 0x20 padding of the type field doesn't interfere.
hawke tested such a change already, so I think it's good to go, but I'll wait for a day for comments.
#1: ext2 won't work if FAT is enabled -------------------------------------+-------------------------------------- Reporter: hawke@hawkesnest.net | Owner: stepan Type: defect | Status: closed Priority: minor | Milestone: FILO 0.6 Component: FILO | Version: Resolution: fixed | Keywords: Dependencies: | Patchstatus: patch has been committed -------------------------------------+-------------------------------------- Changes (by oxygene):
* status: assigned => closed * patchstatus: patch needs review => patch has been committed * resolution: => fixed
-
FILO