[PATCH] artecgroup/dbe61: Set up some video memory, as the device has VGA output.

[Mart Raudsepp]

artecgroup/dbe61: Set up some video memory, as the device has VGA output.

This allows me to have a working coreinfo payload on DBE61 with coreboot-v3.

Signed-off-by: Mart Raudsepp 
---
Outside suggested commit message note:

I think geode_video_mb should be a Kconfig option for boards that have
video output possible at all. The 16MB is picked because 8MB is not enough
for WinCE, but this much is often not necessary to be allocated for other
uses, so configurability would be nice.

mainboard/artecgroup/dbe61/dts |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/mainboard/artecgroup/dbe61/dts b/mainboard/artecgroup/dbe61/dts
index fb51f60..f3d4de5 100644
--- a/mainboard/artecgroup/dbe61/dts
+++ b/mainboard/artecgroup/dbe61/dts
@@ -81,6 +81,8 @@ end
    };
    domain@0 {
    	/config/("northbridge/amd/geodelx/domain");
+		/* Video RAM has to be in 2MB chunks. */
+		geode_video_mb = "16";
    	pci@1,0 {
    		/config/("northbridge/amd/geodelx/pci");
    	};

[PATCH] artecgroup/dbe61: Set up some video memory, as the device has VGA output.

[ron minnich]

On Tue, May 27, 2008 at 5:27 PM, Mart Raudsepp
 wrote:
> artecgroup/dbe61: Set up some video memory, as the device has VGA output.
>
> This allows me to have a working coreinfo payload on DBE61 with coreboot-v3.
> Signed-off-by: Mart Raudsepp
>
> Outside suggested commit message note:
>
> I think geode_video_mb should be a Kconfig option for boards that have
> video output possible at all. The 16MB is picked because 8MB is not enough
> for WinCE, but this much is often not necessary to be allocated for other
> uses, so configurability would be nice.

I agree. This points to an issue in our scheme :-)

Anyway,

Acked-by: Ronald G. Minnich

let me know when wince is up ...

ron

[Carl-Daniel Hailfinger]

On 28.05.2008 02:27, Mart Raudsepp wrote:
> artecgroup/dbe61: Set up some video memory, as the device has VGA output.
>
> This allows me to have a working coreinfo payload on DBE61 with coreboot-v3.
> Signed-off-by: Mart Raudsepp
>
> Outside suggested commit message note:
>
> I think geode_video_mb should be a Kconfig option for boards that have
> video output possible at all. The 16MB is picked because 8MB is not enough
> for WinCE, but this much is often not necessary to be allocated for other
> uses, so configurability would be nice.

Why not include that in the commit message? That way, we'll know in 2
years from now why this was set to 16 MB.

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel