[PATCH] Add TINY_BOOTBLOCK support for AMD SB700

[Uwe Hermann]

See patch.

Uwe.

[Peter Stuge]

Uwe Hermann wrote:
> Add TINY_BOOTBLOCK support for AMD SB700.
>
> Factor out the ROM decode enable functionality into bootblock.c and
> handle it via the usual TINY_BOOTBLOCK mechanism.
>
> Use "select TINY_BOOTBLOCK" in the southbridge, not individual boards.
>
> Signed-off-by: Uwe Hermann

Acked-by: Peter Stuge

But please:
> +/*
> Enable 1MB (LPC) ROM access at 0xFFF00000 - 0xFFFFFFFF.
> Hardware should enable LPC ROM by pin straps. This function does not
> handle the theoretically possible PCI ROM, FWH, or SPI ROM configurations.
> The SB700 power-on default is to map 256K ROM space.
> Details: AMD SB700/710/750 BIOS Developer's Guide (BDG), page 14.
> */
>
> +static void sb700_enable_rom(void)

..make this an unambiguous reference, and I like having the document
number as in the old comment. Maybe even a link, but at least doc nr
and version. Maybe also section besides the page nr.

//Peter

[Uwe Hermann]

On Thu, Dec 09, 2010 at 11:35:52PM +0100, Peter Stuge wrote:
> Acked-by: Peter Stuge
>
> But please:

[...]
> > Details: AMD SB700/710/750 BIOS Developer's Guide (BDG), page 14.
>
> ..make this an unambiguous reference, and I like having the document
> number as in the old comment. Maybe even a link, but at least doc nr
> and version. Maybe also section besides the page nr.

Thanks, r6159. Added the document data/version/PN and the section.
Not sure about the URL, we have those already in the wiki at

http://www.coreboot.org/Datasheets#AMD_SB700.2FSB710.2FSB750

Uwe.