QA: Properly relay results of `checkpatch.pl` check

[Paul Menzel]

Dear coreboot folks,

Each commit pushed to Gerrit is automatically tested for “formal”
issues by using `checkpatch.pl`. See for example [1].

Though despite missing a space violating our coding style, which is
also found by `checkpatch.pl` [2], the comment contains, that no errors
is found.
> https://qa.coreboot.org/job/coreboot-checkpatch/5142/ : SUCCESS

```
ERROR: space required before the open brace '{'
#49: FILE: src/mainboard/google/gru/pwm_regulator.c:61:
+	} else if (IS_ENABLED(CONFIG_BOARD_GOOGLE_KEVIN) && board_id() >= 6){

total: 1 errors, 0 warnings, 49 lines checked
```

Is there a reason for not relaying these errors?

If not, it’d be great to do so (and for the Chromium and Intel folks to
also do that in their repository).

Thanks,

Paul

[1] https://review.coreboot.org/18460
[2] https://qa.coreboot.org/job/coreboot-checkpatch/5142/console

[Martin Roth]

Hi Paul,
  checkpatch is currently not a gating item in jenkins and should always
pass right now.  The checkpatch build was added to jenkins to allow people
to see at the results of the console output for the patch without having to
download and run checkpatch themselves.

Unfortunately, checkpatch is a lot stricter than we want to be.  It would
require someone who fixes a misspelling on a line to also fix any other
mistakes on that line.  Because of this, we don't want to fail the patch
based on checkpatch errors styleguide issues.  We had discussed adding a
non-failing 'lint' flag to gerrit to notify people that checkpatch was
failing so that they could go look at it, but due to people's workloads,
this hasn't happened yet.  Honestly, it's probably fallen off the radar.

Personally, I still think it's a bad idea to refuse patches that don't pass
checkpatch, but I'd be glad to discuss it.

Also, the error you mentioned WAS noticed, and fixed in a follow-on patch
so that it could be pulled back into the chromium tree.

Martin

On Thu, Feb 23, 2017 at 2:16 PM, Paul Menzel via coreboot <
[e-mail]> wrote:
> Dear coreboot folks,
>
> Each commit pushed to Gerrit is automatically tested for “formal”
> issues by using `checkpatch.pl`. See for example [1].
>
> Though despite missing a space violating our coding style, which is
> also found by `checkpatch.pl` [2], the comment contains, that no errors
> is found.
> > https://qa.coreboot.org/job/coreboot-checkpatch/5142/ : SUCCESS
> ERROR: space required before the open brace '{'
> #49: FILE: src/mainboard/google/gru/pwm_regulator.c:61:
> +       } else if (IS_ENABLED(CONFIG_BOARD_GOOGLE_KEVIN) && board_id() >=
> 6){
>
> total: 1 errors, 0 warnings, 49 lines checked
>
> Is there a reason for not relaying these errors?
>
> If not, it’d be great to do so (and for the Chromium and Intel folks to
> also do that in their repository).
>
> Thanks,
>
> Paul
>
> [1] https://review.coreboot.org/18460
> [2] https://qa.coreboot.org/job/coreboot-checkpatch/5142/console
> --
> coreboot mailing list: [e-mail]
> https://www.coreboot.org/mailman/listinfo/coreboot