[LinuxBIOS] i802801DB Error?

I keep getting this error message when building, anyone know what this means??
Is there a bug in the i82801db_lpc.c file?

---------------------------------------
i82801db_lpc.o  
/root/LinuxBIOSv2-2564/src/southbridge/intel/i82801db/i82801db_lpc.c
/root/LinuxBIOSv2-2564/src/southbridge/intel/i82801db/i82801db_lpc.c:415:  
error: ?PCI_DEVICE_ID_INTEL_82801DB_ISA? undeclared here (not in a  
function)
make[1]: *** [i82801db_lpc.o] Error 1
make[1]: Leaving directory  
`/root/LinuxBIOSv2-2564/targets/rca/rm4100/rm4100/normal'
make: *** [normal/linuxbios.rom] Error 1
----------------------------------------

Thanks - Joe

[Corey Osgood]

[e-mail] wrote:
> I keep getting this error message when building, anyone know what this means??
> Is there a bug in the i82801db_lpc.c file?
>
> i82801db_lpc.o  
> /root/LinuxBIOSv2-2564/src/southbridge/intel/i82801db/i82801db_lpc.c
> /root/LinuxBIOSv2-2564/src/southbridge/intel/i82801db/i82801db_lpc.c:415:  
> error: ?PCI_DEVICE_ID_INTEL_82801DB_ISA? undeclared here (not in a  
> function)
> make[1]: *** [i82801db_lpc.o] Error 1
> make[1]: Leaving directory  
> `/root/LinuxBIOSv2-2564/targets/rca/rm4100/rm4100/normal'
> make: *** [normal/linuxbios.rom] Error 1
>
> Thanks - Joe

Add "#include <device/pci_ids.h>" (without quotes) to the top of the file.

-Corey

Quoting Corey Osgood :
> [e-mail] wrote:
> > I keep getting this error message when building, anyone know what   
> > this means??
> > Is there a bug in the i82801db_lpc.c file?
> >
> > i82801db_lpc.o
> > /root/LinuxBIOSv2-2564/src/southbridge/intel/i82801db/i82801db_lpc.c
> > /root/LinuxBIOSv2-2564/src/southbridge/intel/i82801db/i82801db_lpc.c:415:
> > error: ?PCI_DEVICE_ID_INTEL_82801DB_ISA? undeclared here (not in a
> > function)
> > make[1]: *** [i82801db_lpc.o] Error 1
> > make[1]: Leaving directory
> > `/root/LinuxBIOSv2-2564/targets/rca/rm4100/rm4100/normal'
> > make: *** [normal/linuxbios.rom] Error 1
> >
> > Thanks - Joe
>
> Add "#include <device/pci_ids.h>" (without quotes) to the top of the file.
>
> -Corey

It's already there? Is there somewhere else I am supposed to define  
PCI_DEVICE_ID_INTEL_82801DB_ISA ??

Thanks - Joe

Quoting [e-mail]:
> Quoting Corey Osgood :
> > [e-mail] wrote:
> > > I keep getting this error message when building, anyone know what
> > > this means??
> > > Is there a bug in the i82801db_lpc.c file?
> > >
> > > i82801db_lpc.o
> > > /root/LinuxBIOSv2-2564/src/southbridge/intel/i82801db/i82801db_lpc.c
> > > /root/LinuxBIOSv2-2564/src/southbridge/intel/i82801db/i82801db_lpc.c:415:
> > > error: ?PCI_DEVICE_ID_INTEL_82801DB_ISA? undeclared here (not in a
> > > function)
> > > make[1]: *** [i82801db_lpc.o] Error 1
> > > make[1]: Leaving directory
> > > `/root/LinuxBIOSv2-2564/targets/rca/rm4100/rm4100/normal'
> > > make: *** [normal/linuxbios.rom] Error 1
> > >
> > > Thanks - Joe
> >
> > Add "#include <device/pci_ids.h>" (without quotes) to the top of the file.
> >
> > -Corey
>
> It's already there? Is there somewhere else I am supposed to define
> PCI_DEVICE_ID_INTEL_82801DB_ISA ??
>
> Thanks - Joe

Also I don't see this defined in pci_ids.h anywhere??

Thanks - Joe

[Corey Osgood]

[e-mail] wrote:
> Quoting [e-mail]:
> > Quoting Corey Osgood :
> > > [e-mail] wrote:
> > > > I keep getting this error message when building, anyone know what
> > > > this means??
> > > > Is there a bug in the i82801db_lpc.c file?
> > > >
> > > > i82801db_lpc.o
> > > > /root/LinuxBIOSv2-2564/src/southbridge/intel/i82801db/i82801db_lpc.c
> > > > /root/LinuxBIOSv2-2564/src/southbridge/intel/i82801db/i82801db_lpc.c:415:
> > > > error: ?PCI_DEVICE_ID_INTEL_82801DB_ISA? undeclared here (not in a
> > > > function)
> > > > make[1]: *** [i82801db_lpc.o] Error 1
> > > > make[1]: Leaving directory
> > > > `/root/LinuxBIOSv2-2564/targets/rca/rm4100/rm4100/normal'
> > > > make: *** [normal/linuxbios.rom] Error 1
> > > >
> > > > Thanks - Joe
> > >
> > > Add "#include <device/pci_ids.h>" (without quotes) to the top of the file.
> > >
> > > -Corey
> >
> > It's already there? Is there somewhere else I am supposed to define
> > PCI_DEVICE_ID_INTEL_82801DB_ISA ??
> >
> > Thanks - Joe
>
> Also I don't see this defined in pci_ids.h anywhere??
>
> Thanks - Joe

Yep, someone's changed things around, either in the device files or
pci_ids.h. Alright, grab an lspci -n and a regular lspci, and figure out
which device ID corresponds to your PCI-to-ISA bridge (I think this is
what it's looking for). Then replace PCI_DEVICE_ID_INTEL_82801DB_ISA
with 0x<value>. Is this for i815 (i82801aa/ba)? If it is, you'll have to
replace the pci ids anyways.

-Corey

Quoting Corey Osgood :
> [e-mail] wrote:
> > Quoting [e-mail]:
> > > Quoting Corey Osgood :
> > > > [e-mail] wrote:
> > > > > I keep getting this error message when building, anyone know what
> > > > > this means??
> > > > > Is there a bug in the i82801db_lpc.c file?
> > > > >
> > > > > i82801db_lpc.o
> > > > > /root/LinuxBIOSv2-2564/src/southbridge/intel/i82801db/i82801db_lpc.c
> > > > > /root/LinuxBIOSv2-2564/src/southbridge/intel/i82801db/i82801db_lpc.c:415:
> > > > > error: ?PCI_DEVICE_ID_INTEL_82801DB_ISA? undeclared here (not in a
> > > > > function)
> > > > > make[1]: *** [i82801db_lpc.o] Error 1
> > > > > make[1]: Leaving directory
> > > > > `/root/LinuxBIOSv2-2564/targets/rca/rm4100/rm4100/normal'
> > > > > make: *** [normal/linuxbios.rom] Error 1
> > > > >
> > > > > Thanks - Joe
> > > >
> > > > Add "#include <device/pci_ids.h>" (without quotes) to the top of the file.
> > > >
> > > > -Corey
> > >
> > > It's already there? Is there somewhere else I am supposed to define
> > > PCI_DEVICE_ID_INTEL_82801DB_ISA ??
> > >
> > > Thanks - Joe
> >
> > Also I don't see this defined in pci_ids.h anywhere??
> >
> > Thanks - Joe
>
> Yep, someone's changed things around, either in the device files or
> pci_ids.h. Alright, grab an lspci -n and a regular lspci, and figure out
> which device ID corresponds to your PCI-to-ISA bridge (I think this is
> what it's looking for). Then replace PCI_DEVICE_ID_INTEL_82801DB_ISA
> with 0x<value>. Is this for i815 (i82801aa/ba)? If it is, you'll have to
> replace the pci ids anyways.
>
> -Corey

Ok, I got it. pci_ids.h currently says:

#define PCI_DEVICE_ID_INTEL_82801DB_0	0x24c0
#define PCI_DEVICE_ID_INTEL_82801DB_2	0x24c2
#define PCI_DEVICE_ID_INTEL_82801DB_3	0x24c3
#define PCI_DEVICE_ID_INTEL_82801DB_4	0x24c4
#define PCI_DEVICE_ID_INTEL_82801DB_5	0x24c5
#define PCI_DEVICE_ID_INTEL_82801DB_6	0x24c6
#define PCI_DEVICE_ID_INTEL_82801DB_7	0x24c7
#define PCI_DEVICE_ID_INTEL_82801DB_11	0x24cb
#define PCI_DEVICE_ID_INTEL_82801DB_13	0x24cd

And it should say:

#define PCI_DEVICE_ID_INTEL_82801DB_ISA	0x24c0
#define PCI_DEVICE_ID_INTEL_82801DB_PCI	0x24c1
#define PCI_DEVICE_ID_INTEL_82801DB_USB0 0x24c2
#define PCI_DEVICE_ID_INTEL_82801DB_SMB	0x24c3
#define PCI_DEVICE_ID_INTEL_82801DB_USB1 0x24c4
#define PCI_DEVICE_ID_INTEL_82801DB_AC97_AUDIO 0x24c5
#define PCI_DEVICE_ID_INTEL_82801DB_AC97_MODEM 0x24c6
#define PCI_DEVICE_ID_INTEL_82801DB_USB2 0x24c7
#define PCI_DEVICE_ID_INTEL_82801DB_IDE	0x24cb
#define PCI_DEVICE_ID_INTEL_82801DB_EHCI 0x24cd

Can someone apply this fix for me?

Thanks - Joe

[Stefan Reinauer]

* [e-mail]  [070302 20:34]:
> Ok, I got it. pci_ids.h currently says:
>
> #define PCI_DEVICE_ID_INTEL_82801DB_0	0x24c0
> #define PCI_DEVICE_ID_INTEL_82801DB_2	0x24c2
> #define PCI_DEVICE_ID_INTEL_82801DB_3	0x24c3
> #define PCI_DEVICE_ID_INTEL_82801DB_4	0x24c4
> #define PCI_DEVICE_ID_INTEL_82801DB_5	0x24c5
> #define PCI_DEVICE_ID_INTEL_82801DB_6	0x24c6
> #define PCI_DEVICE_ID_INTEL_82801DB_7	0x24c7
> #define PCI_DEVICE_ID_INTEL_82801DB_11	0x24cb
> #define PCI_DEVICE_ID_INTEL_82801DB_13	0x24cd
>
> And it should say:
>
> #define PCI_DEVICE_ID_INTEL_82801DB_ISA	0x24c0
> #define PCI_DEVICE_ID_INTEL_82801DB_PCI	0x24c1
> #define PCI_DEVICE_ID_INTEL_82801DB_USB0 0x24c2
> #define PCI_DEVICE_ID_INTEL_82801DB_SMB	0x24c3
> #define PCI_DEVICE_ID_INTEL_82801DB_USB1 0x24c4
> #define PCI_DEVICE_ID_INTEL_82801DB_AC97_AUDIO 0x24c5
> #define PCI_DEVICE_ID_INTEL_82801DB_AC97_MODEM 0x24c6
> #define PCI_DEVICE_ID_INTEL_82801DB_USB2 0x24c7
> #define PCI_DEVICE_ID_INTEL_82801DB_IDE	0x24cb
> #define PCI_DEVICE_ID_INTEL_82801DB_EHCI 0x24cd
>
> Can someone apply this fix for me?

Can you provide a unified diff (svn diff) and send it to the list?

[Uwe Hermann]

On Sat, Mar 03, 2007 at 07:11:35PM +0100, Stefan Reinauer wrote:
> [e-mail]  [070302 20:34]:
> > Ok, I got it. pci_ids.h currently says:
> >
> > #define PCI_DEVICE_ID_INTEL_82801DB_0	0x24c0
> > #define PCI_DEVICE_ID_INTEL_82801DB_2	0x24c2
> > #define PCI_DEVICE_ID_INTEL_82801DB_3	0x24c3
> > #define PCI_DEVICE_ID_INTEL_82801DB_4	0x24c4
> > #define PCI_DEVICE_ID_INTEL_82801DB_5	0x24c5
> > #define PCI_DEVICE_ID_INTEL_82801DB_6	0x24c6
> > #define PCI_DEVICE_ID_INTEL_82801DB_7	0x24c7
> > #define PCI_DEVICE_ID_INTEL_82801DB_11	0x24cb
> > #define PCI_DEVICE_ID_INTEL_82801DB_13	0x24cd
> >
> > And it should say:
> >
> > #define PCI_DEVICE_ID_INTEL_82801DB_ISA	0x24c0
> > #define PCI_DEVICE_ID_INTEL_82801DB_PCI	0x24c1
> > #define PCI_DEVICE_ID_INTEL_82801DB_USB0 0x24c2
> > #define PCI_DEVICE_ID_INTEL_82801DB_SMB	0x24c3
> > #define PCI_DEVICE_ID_INTEL_82801DB_USB1 0x24c4
> > #define PCI_DEVICE_ID_INTEL_82801DB_AC97_AUDIO 0x24c5
> > #define PCI_DEVICE_ID_INTEL_82801DB_AC97_MODEM 0x24c6
> > #define PCI_DEVICE_ID_INTEL_82801DB_USB2 0x24c7
> > #define PCI_DEVICE_ID_INTEL_82801DB_IDE	0x24cb
> > #define PCI_DEVICE_ID_INTEL_82801DB_EHCI 0x24cd
> >
> > Can someone apply this fix for me?
>
> Can you provide a unified diff (svn diff) and send it to the list?

The pci_ids.h from the Linux kernel (which ours is based on) has only
the PCI_DEVICE_ID_INTEL_82801DB_12 etc. defines (with numbers).

Shall we fix our code to use the numbers? Or maybe add something like
this at the end of pci_ids.h:

#define PCI_DEVICE_ID_INTEL_82801DB_ISA  PCI_DEVICE_ID_INTEL_82801DB_0
#define PCI_DEVICE_ID_INTEL_82801DB_USB0 PCI_DEVICE_ID_INTEL_82801DB_2
...

I'd like to stay as close as reasonably possible to the pci_ids.h from
Linux, so that we can easily sync with the Linux version from time to
time...

Uwe.

Quoting Uwe Hermann :
> On Sat, Mar 03, 2007 at 07:11:35PM +0100, Stefan Reinauer wrote:
> > [e-mail]  [070302 20:34]:
> > > Ok, I got it. pci_ids.h currently says:
> > >
> > > #define PCI_DEVICE_ID_INTEL_82801DB_0	0x24c0
> > > #define PCI_DEVICE_ID_INTEL_82801DB_2	0x24c2
> > > #define PCI_DEVICE_ID_INTEL_82801DB_3	0x24c3
> > > #define PCI_DEVICE_ID_INTEL_82801DB_4	0x24c4
> > > #define PCI_DEVICE_ID_INTEL_82801DB_5	0x24c5
> > > #define PCI_DEVICE_ID_INTEL_82801DB_6	0x24c6
> > > #define PCI_DEVICE_ID_INTEL_82801DB_7	0x24c7
> > > #define PCI_DEVICE_ID_INTEL_82801DB_11	0x24cb
> > > #define PCI_DEVICE_ID_INTEL_82801DB_13	0x24cd
> > >
> > > And it should say:
> > >
> > > #define PCI_DEVICE_ID_INTEL_82801DB_ISA	0x24c0
> > > #define PCI_DEVICE_ID_INTEL_82801DB_PCI	0x24c1
> > > #define PCI_DEVICE_ID_INTEL_82801DB_USB0 0x24c2
> > > #define PCI_DEVICE_ID_INTEL_82801DB_SMB	0x24c3
> > > #define PCI_DEVICE_ID_INTEL_82801DB_USB1 0x24c4
> > > #define PCI_DEVICE_ID_INTEL_82801DB_AC97_AUDIO 0x24c5
> > > #define PCI_DEVICE_ID_INTEL_82801DB_AC97_MODEM 0x24c6
> > > #define PCI_DEVICE_ID_INTEL_82801DB_USB2 0x24c7
> > > #define PCI_DEVICE_ID_INTEL_82801DB_IDE	0x24cb
> > > #define PCI_DEVICE_ID_INTEL_82801DB_EHCI 0x24cd
> > >
> > > Can someone apply this fix for me?
> >
> > Can you provide a unified diff (svn diff) and send it to the list?
>
> The pci_ids.h from the Linux kernel (which ours is based on) has only
> the PCI_DEVICE_ID_INTEL_82801DB_12 etc. defines (with numbers).
>
> Shall we fix our code to use the numbers? Or maybe add something like
> this at the end of pci_ids.h:
>
> #define PCI_DEVICE_ID_INTEL_82801DB_ISA  PCI_DEVICE_ID_INTEL_82801DB_0
> #define PCI_DEVICE_ID_INTEL_82801DB_USB0 PCI_DEVICE_ID_INTEL_82801DB_2
> ...
>
> I'd like to stay as close as reasonably possible to the pci_ids.h from
> Linux, so that we can easily sync with the Linux version from time to
> time...
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

Than should we just modify the code in the  
/src/southbridge/intel/i82801db directory?

Thanks - Joe

[ron minnich]

yes, the linux pci_ids.h has changed over the years. So, you take a
snapshot of it, write code around it, then find that all your ids are
gone in the next version ;-(

that's the danger of using inlcude files from elsewhere :-)

ron