[PATCH] The function int15 running on the Technexion's tim5690.

[Libra Li]

Hello,

This patch has RS690 function int15.
    The VGA BIOS is through int15 getting LCD panel's ID.
    The panel's ID is selection by switch.
    This functions is reference "AMD RS690 ASIC Family BIOS Developer’s
Guide".

Thanks.

Signed-off-by: Libra Li

[PATCH] The function int15 running on the Technexion's tim5690.

[Marc Jones]

On Mon, Dec 14, 2009 at 5:27 AM, Libra Li  wrote:
> Hello,
>
> This patch has RS690 function int15.
>     The VGA BIOS is through int15 getting LCD panel's ID.
>     The panel's ID is selection by switch.
>     This functions is reference "AMD RS690 ASIC Family BIOS Developer’s
> Guide".
>
> Thanks.
>
> Signed-off-by: Libra Li

Hi Libra Li,

I understand that you need the int15 vbios call back for your platform
support, but we need to find a way to add it that doesn't put 690
specific code into the generic int15 handler,
util/x86emu/x86_interrupts.c. Can you fix this to move the code to a
690 specific file and to only include the case AMD_RS690_INT15: is it
is a RS690 system built? src/include/vbios.h should be moved to an AMD
690 directory as well.

Thanks,
Marc

[PATCH] The function int15 running on the Technexion's tim5690.

[Libra Li]

Hi Marc,

Where do I create the directories? In "src/util"? Your think?

Thanks.
    Libra.

2009/12/14 Marc Jones
> On Mon, Dec 14, 2009 at 5:27 AM, Libra Li  wrote:
> > Hello,
> > This patch has RS690 function int15.
> > The VGA BIOS is through int15 getting LCD panel's ID.
> > The panel's ID is selection by switch.
> > This functions is reference "AMD RS690 ASIC Family BIOS Developer’s
> >
> > Guide".
> > Thanks.
> >
> > Signed-off-by: Libra Li <[e-mail]>
>
> Hi Libra Li,
>
> I understand that you need the int15 vbios call back for your platform
> support, but we need to find a way to add it that doesn't put 690
> specific code into the generic int15 handler,
> util/x86emu/x86_interrupts.c. Can you fix this to move the code to a
> 690 specific file and to only include the case AMD_RS690_INT15: is it
> is a RS690 system built? src/include/vbios.h should be moved to an AMD
> 690 directory as well.
>
> Thanks,
> Marc

[PATCH] The function int15 running on the Technexion's tim5690.

[Marc Jones]

On Mon, Dec 14, 2009 at 8:12 PM, Libra Li  wrote:
> Hi Marc,
>
> Where do I create the directories? In "src/util"? Your think?

I think I would put it in the src/southbridge/amd/rs690 but i could be
convinced to add a 690 file to the emulator directory.

Other opinions?

Marc

[PATCH] The function int15 running on the Technexion's tim5690.

[ron minnich]

On Tue, Dec 15, 2009 at 8:31 AM, Marc Jones  wrote:
> On Mon, Dec 14, 2009 at 8:12 PM, Libra Li  wrote:
> > Hi Marc,
> >
> > Where do I create the directories? In "src/util"? Your think?
>
> I think I would put it in the src/southbridge/amd/rs690 but i could be
> convinced to add a 690 file to the emulator directory.
>
> Other opinions?

source in src/southbridge/amd/rs690 and point to the code in the
emulator either use linker-sets and
objs-$(CONFIG_SOUTHBRIDGE_AMD_RS690) += whatever.o

Mr. Li, it may take a bit longer to do this in this manner, but we
will take a bit of extra time to do this carefully. I hope that is ok.

Thanks

ron

[PATCH] The function int15 running on the Technexion's tim5690.

[Stefan Reinauer]

On 12/15/09 5:31 PM, Marc Jones wrote:
> On Mon, Dec 14, 2009 at 8:12 PM, Libra Li  wrote:
> > Hi Marc,
> > Where do I create the directories? In "src/util"? Your think?
>
> I think I would put it in the src/southbridge/amd/rs690 but i could be
> convinced to add a 690 file to the emulator directory.
>
> Other opinions?

I think it should go to southbridge/amd/rs690, or even to the mainboard
directory, if it's about detecting a specific LCD version.

I know Yabel has a method of attaching your own int15 handler easily,
but x86 realmode has not (i could well use this on one of the systems I
am working on, but didn't get around to implementing it.. )

Stefan

[PATCH] The function int15 running on the Technexion's tim5690.

[ron minnich]

On Tue, Dec 15, 2009 at 9:30 AM, Stefan Reinauer  wrote:
> I think it should go to southbridge/amd/rs690, or even to the mainboard
> directory, if it's about detecting a specific LCD version.

oops. You're right. Mainboard directory.

Should we use the weak symbols thing for attaching handlers like this?

So the default in yabel is a weak symbol and can be over-ridden by a
compiled in handler?

ron

[PATCH] The function int15 running on the Technexion's tim5690.

[Libra Li]

Hello,

I modified int15_handler on mainboard.

The VGA BIOS is through int15 getting LCD panel's ID. Then the VBIOS
call int15.
    The panel's ID is selection by switch.
    This functions is reference "AMD RS690 ASIC Family BIOS Developer’s
Guide".

Thanks.

Signed-off-by: Libra Li

2009/12/16 ron minnich
> On Tue, Dec 15, 2009 at 9:30 AM, Stefan Reinauer 
> wrote:
> > I think it should go to southbridge/amd/rs690, or even to the mainboard
> > directory, if it's about detecting a specific LCD version.
>
> oops. You're right. Mainboard directory.
>
> Should we use the weak symbols thing for attaching handlers like this?
>
> So the default in yabel is a weak symbol and can be over-ridden by a
> compiled in handler?
>
> ron

[PATCH] The function int15 running on the Technexion's tim5690.

[Libra Li]

Hi,

Sorry. I'm loss some data in the last patch file.
    This a new patch is okay.

The VGA BIOS is through int15 getting LCD panel ID. Then the VBIOS call
int15's "Get LCD panel ID".
    The panel ID is selection by switch.
    This function is reference "AMD RS690 ASIC Family BIOS Developer's
Guide".

Thanks.

Signed-off-by: Libra Li

2009/12/17 Libra Li
> Hello,
> I modified int15_handler on mainboard.
>
> The VGA BIOS is through int15 getting LCD panel's ID. Then the VBIOS
>
> call int15.
> The panel's ID is selection by switch.
> This functions is reference "AMD RS690 ASIC Family BIOS Developer’s
>
> Guide".
> Thanks.
>
> Signed-off-by: Libra Li <[e-mail]>
>
>
> 2009/12/16 ron minnich
>
> On Tue, Dec 15, 2009 at 9:30 AM, Stefan Reinauer
> > wrote:
> > > I think it should go to southbridge/amd/rs690, or even to the mainboard
> > > directory, if it's about detecting a specific LCD version.
> >
> > oops. You're right. Mainboard directory.
> >
> > Should we use the weak symbols thing for attaching handlers like this?
> >
> > So the default in yabel is a weak symbol and can be over-ridden by a
> > compiled in handler?
> >
> > ron