x60 and macbook21 builds fail

[Mono]

is it just me? trying to build coreboot for a X60 motherboard or a macbook21 fails with tons of the following error:

src/northbridge/intel/i945/gma.c: In function 'gtt_setup':
src/northbridge/intel/i945/gma.c:72:10: error: passing argument 1 of 'write32' makes pointer from integer without a cast [-Werror]
  write32(mmiobase + GFX_FLSH_CNTL, 0);
          ^
In file included from src/include/device/pci.h:23:0,
                 from src/northbridge/intel/i945/gma.c:24:
src/arch/x86/include/arch/io.h:170:51: note: expected 'volatile void *' but argument is of type 'unsigned int'
 static inline __attribute__((always_inline)) void write32(volatile void *addr, uint32_t value)
                                                   ^
src/northbridge/intel/i945/gma.c:74:10: error: passing argument 1 of 'write32' makes pointer from integer without a cast [-Werror]
  write32(mmiobase + PGETBL_CTL, PGETBL_save);

I figured this error occurs since commit bde6d309 (x86: Change MMIO addr in readN(addr)/writeN(addr, val) to pointer). I don't know how to fix it though or did I configured any wrong? Any help is much appreciated.

greets
Mono

[Alexandru Gagniuc]

On Thursday, March 12, 2015 10:35:23 PM Mono wrote:
> is it just me? trying to build coreboot for a X60 motherboard or a macbook21
> fails with tons of the following error:
>
> src/northbridge/intel/i945/gma.c: In function 'gtt_setup':
> src/northbridge/intel/i945/gma.c:72:10: error: passing argument 1 of
> 'write32' makes pointer from integer without a cast [-Werror]
> write32(mmiobase + GFX_FLSH_CNTL, 0);
>           ^

Yeah. I broke that one. write32() takes a void * (as opposed to long int), so 
you'll have to pass it void pointers,
> In file included from src/include/device/pci.h:23:0,
>                  from src/northbridge/intel/i945/gma.c:24:
> src/arch/x86/include/arch/io.h:170:51: note: expected 'volatile void *' but
> argument is of type 'unsigned int' static inline
> __attribute__((always_inline)) void write32(volatile void *addr, uint32_t
> value) ^
> src/northbridge/intel/i945/gma.c:74:10: error: passing argument 1 of
> 'write32' makes pointer from integer without a cast [-Werror]
> write32(mmiobase + PGETBL_CTL, PGETBL_save);
>
> I figured this error occurs since commit bde6d309 (x86: Change MMIO addr in
> readN(addr)/writeN(addr, val) to pointer). I don't know how to fix it
> though or did I configured any wrong? Any help is much appreciated.

You can make mmiobase a uint8_t * then you can use the same pointer arithmetic 
as before.

Alex
> greets
> Mono

[Kevin Paul Herbert]

Not sure how I missed this, unless util/abuild does not rebuild it.

I can fix this.

Kevin
> On Mar 12, 2015, at 21:48, Alexandru Gagniuc  wrote:
> > On Thursday, March 12, 2015 10:35:23 PM Mono wrote:
> > is it just me? trying to build coreboot for a X60 motherboard or a macbook21
> > fails with tons of the following error:
> >
> > src/northbridge/intel/i945/gma.c: In function 'gtt_setup':
> > src/northbridge/intel/i945/gma.c:72:10: error: passing argument 1 of
> > 'write32' makes pointer from integer without a cast [-Werror]
> > write32(mmiobase + GFX_FLSH_CNTL, 0);
> >          ^
>
> Yeah. I broke that one. write32() takes a void * (as opposed to long int), so 
> you'll have to pass it void pointers,
> > In file included from src/include/device/pci.h:23:0,
> >                 from src/northbridge/intel/i945/gma.c:24:
> > src/arch/x86/include/arch/io.h:170:51: note: expected 'volatile void *' but
> > argument is of type 'unsigned int' static inline
> > __attribute__((always_inline)) void write32(volatile void *addr, uint32_t
> > value) ^
> > src/northbridge/intel/i945/gma.c:74:10: error: passing argument 1 of
> > 'write32' makes pointer from integer without a cast [-Werror]
> > write32(mmiobase + PGETBL_CTL, PGETBL_save);
> >
> > I figured this error occurs since commit bde6d309 (x86: Change MMIO addr in
> > readN(addr)/writeN(addr, val) to pointer). I don't know how to fix it
> > though or did I configured any wrong? Any help is much appreciated.
>
> You can make mmiobase a uint8_t * then you can use the same pointer arithmetic 
> as before.
>
> Alex
> > greets
> > Mono

[Paul Menzel]

Dear Kevin,

Am Donnerstag, den 12.03.2015, 23:08 -0700 schrieb Kevin Paul Herbert:
> Not sure how I missed this, unless util/abuild does not rebuild it.

native graphics is not selected by default. Next time change set #5957
[1] should be rebased on top to get it build tested.

Thanks,

Paul

[1] http://review.coreboot.org/5957

[Kevin Herbert]

Thanks! I’ll keep that in mind when I next submit patches.

Kevin
> On Mar 13, 2015, at 12:19 AM, Paul Menzel  wrote:
>
> Dear Kevin,
>
> Am Donnerstag, den 12.03.2015, 23:08 -0700 schrieb Kevin Paul Herbert:
> > Not sure how I missed this, unless util/abuild does not rebuild it.
>
> native graphics is not selected by default. Next time change set #5957
> [1] should be rebased on top to get it build tested.
>
> Thanks,
>
> Paul
> [1] http://review.coreboot.org/5957
>
> coreboot mailing list: [e-mail]
> http://www.coreboot.org/mailman/listinfo/coreboot