Re: [coreboot] F71889 Super I/O patch

[Neo The User]

Signed-off-by: Alec Ari

--- On Wed, 11/3/10, Neo The User  wrote:
> From: Neo The User 
> Subject: F71889 Super I/O patch
> To: [e-mail]
> Date: Wednesday, November 3, 2010, 5:55 PM
> Hello, I looked over the F71889
> Fintek datasheet, and its very similar to the F71863FG I
> noticed. I used sed to replace some of the names around and
> such. I haven't tested it, nor will I, since I have little
> to no experience with flashing devices, and have no back-up
> (can't recover) and I do have a stub (that most likely wont
> work) for the MSI MS785GT-E63 board, and it compiled fine
> and all, using the F71889 code, I mainly just changed the
> romstage.c file around to make it fit, while still basing
> the code off the other 785 boards. If anybody wants to test
> the F71889 patch, feel free.
>
> Also I wasn't sure to keep the same name in the other
> Fintek chips or not, so I changed the name to mine, and the
> year. I apologize if that was incorrect, and will be more
> than willing to keep the original GNU header.
>
> Some indentation was changed when using svn diff to
> generate the patch.
>
> -Alec Ari

F71889 Super I/O patch

[Uwe Hermann]

On Wed, Nov 03, 2010 at 12:18:56PM -0700, Neo The User wrote:
> Signed-off-by: Alec Ari

Thanks, committed in r6017 with a few changes:

- Changed unsigned int etc. to u8/u16 etc. everywhere.

- Add the missing LDNs as per datasheet to f71889.h and added superio.c
   code to handle the devices (at least partially).

- Add KBC stuff, this Super I/O _does_ have a keyboard LDN.

- Fixed up pnp_dev_info as good as possible, but it seems the datasheet
   is missing some info needed to asses where to use 0x7f8 or 0xff8 etc.
> > the code off the other 785 boards. If anybody wants to test
> > the F71889 patch, feel free.

Yup, but testing is not strictly required, I'm relatively sure the
code as committed should work (though there are some TODOs).
> > Also I wasn't sure to keep the same name in the other
> > Fintek chips or not, so I changed the name to mine, and the

Yep, that's fine for such simple pieces of code which cannot be written
much differently anyways. But please do keep the (C) lines intact
when deriving/copying larger and more complex pieces of code.
> > year. I apologize if that was incorrect, and will be more
> > than willing to keep the original GNU header.

There's no such thing as a "GNU header" btw. Every file has one or
more "(C) Copyright" line(s) which list the copyright holder(s) and
the resp. years, and a text-blob which describes the license that
applies to that file (in this case it happens to be the GNU GPL).

Uwe.