Re: [LinuxBIOS] r447 - in LinuxBIOSv3: include/device mainboard/emulation/qemu-x86

[Stefan Reinauer]

* [e-mail] <[e-mail]> [070712 03:03]:
> Some minor cosmetic fixes (trivial).
> -/* no printk allowed until hardware is ready; hardware is ready */
>  /** 
> - * start up hardware needed for stage1
> + * Start up hardware needed for stage1.
> + *
> + * No printk() allowed until hardware is ready; hardware is ready.
> + * TODO: Fix above comment? It's unclear.
>   */

I don't think it is. Without hardware to print on, no printk. What's
unclear with that?

I also think this should not go into the doxygen comment.

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: [phone] • Fax: [phone]
Email: [e-mail]  • http://www.coresystems.de/

[LinuxBIOS] r447 - in LinuxBIOSv3: include/device mainboard/emulation/qemu-x86

[Peter Stuge]

On Thu, Jul 12, 2007 at 10:53:17AM +0200, Stefan Reinauer wrote:
> > + * No printk() allowed until hardware is ready; hardware is ready.
> > + * TODO: Fix above comment? It's unclear.
>
> I don't think it is. Without hardware to print on, no printk.
> What's unclear with that?

"hardware is ready" twice - is that just a mistake?


//Peter

[LinuxBIOS] r447 - in LinuxBIOSv3: include/device mainboard/emulation/qemu-x86

[Uwe Hermann]

On Thu, Jul 12, 2007 at 10:53:17AM +0200, Stefan Reinauer wrote:
> * [e-mail] <[e-mail]> [070712 03:03]:
> > Some minor cosmetic fixes (trivial).
> > -/* no printk allowed until hardware is ready; hardware is ready */
> >  /** 
> > - * start up hardware needed for stage1
> > + * Start up hardware needed for stage1.
> > + *
> > + * No printk() allowed until hardware is ready; hardware is ready.
> > + * TODO: Fix above comment? It's unclear.
> >   */
>
> I don't think it is. Without hardware to print on, no printk. What's
> unclear with that?

Hm, I don't understand the intention and why it's in that file.

Sure, as a general comment it's correct. If you don't have hardware you
cannot print on it. For QEMU this is not correct, though, it emulates
a serial console (and/or VGA console), so it _is_ posible to pritnk().

Is the comment supposed to say that we don't need special UART init
for QEMU, as it will work right from the start?

The comment just confuses me.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org