Hey all - following on Marc's awesome Barcelona patches, here is the code to add the fam10 target to buildrom. You may see a stack protect problem, patches following shortly to deal with that.
Jordan
Hey all - following on Marc's awesome Barcelona patches, here is the code to add the fam10 target to buildrom.
It works for me, but since you used the generic.mk instead of a specific one, it didn't catch that I didn't have iasl installed.
That said, it seems like it would be nicer to have a FAMILY_10 option and just take care of the three variables that change in Serengeti_cheetah.conf. That way you get 64-bit support and the iasl check for free.
If you still want to keep it separate, I'd like the name to be Serengeti_cheetah_fam_10.conf instead of cheetah_fam_10.conf, so it's easy to see what it is.
Myles
Myles Watson wrote:
Hey all - following on Marc's awesome Barcelona patches, here is the code to add the fam10 target to buildrom.
It works for me, but since you used the generic.mk instead of a specific one, it didn't catch that I didn't have iasl installed.
That said, it seems like it would be nicer to have a FAMILY_10 option and just take care of the three variables that change in Serengeti_cheetah.conf. That way you get 64-bit support and the iasl check for free.
If you still want to keep it separate, I'd like the name to be Serengeti_cheetah_fam_10.conf instead of cheetah_fam_10.conf, so it's easy to see what it is.
Myles
Myles,
I agree using the same serengeti_cheetah.conf is better so here is my attempt......
Marc
On Dec 20, 2007 12:15 PM, Marc Jones Marc.Jones@amd.com wrote:
Myles Watson wrote:
Hey all - following on Marc's awesome Barcelona patches, here is the code to add the fam10 target to buildrom.
It works for me, but since you used the generic.mk instead of a specific one, it didn't catch that I didn't have iasl installed.
That said, it seems like it would be nicer to have a FAMILY_10 option and just take care of the three variables that change in Serengeti_cheetah.conf. That way you get 64-bit support and the iasl check for free.
If you still want to keep it separate, I'd like the name to be Serengeti_cheetah_fam_10.conf instead of cheetah_fam_10.conf, so it's easy to see what it is.
Myles
Myles,
I agree using the same serengeti_cheetah.conf is better so here is my attempt......
Marc
It works for me with the attached patch, which patches the fam10 Config.lb instead of the serengeti_cheetah/Config.lb for changing the payload.
If you add this, or something that is cleaner I'll test and ack it.
Myles
Myles Watson wrote:
On Dec 20, 2007 12:15 PM, Marc Jones Marc.Jones@amd.com wrote:
Myles Watson wrote:
Hey all - following on Marc's awesome Barcelona patches, here is the code to add the fam10 target to buildrom.
It works for me, but since you used the generic.mk instead of a specific one, it didn't catch that I didn't have iasl installed.
That said, it seems like it would be nicer to have a FAMILY_10 option and just take care of the three variables that change in Serengeti_cheetah.conf. That way you get 64-bit support and the iasl check for free.
If you still want to keep it separate, I'd like the name to be Serengeti_cheetah_fam_10.conf instead of cheetah_fam_10.conf, so it's easy to see what it is.
Myles
Myles,
I agree using the same serengeti_cheetah.conf is better so here is my attempt......
Marc
It works for me with the attached patch, which patches the fam10 Config.lb instead of the serengeti_cheetah/Config.lb for changing the payload.
If you add this, or something that is cleaner I'll test and ack it.
Myles
Ah! missed the LAB stuff, sorry. I will make those changes. Is the serengeti_cheetah_fam10-payload.patch really needed? It cleans up the config.lb a little but I don't see a functional difference.
Marc
Myles Watson wrote:
On Dec 20, 2007 12:15 PM, Marc Jones Marc.Jones@amd.com wrote:
Myles Watson wrote:
Hey all - following on Marc's awesome Barcelona patches, here is the code to add the fam10 target to buildrom.
It works for me, but since you used the generic.mk instead of a
specific
one, it didn't catch that I didn't have iasl installed.
That said, it seems like it would be nicer to have a FAMILY_10 option
and
just take care of the three variables that change in
Serengeti_cheetah.conf.
That way you get 64-bit support and the iasl check for free.
If you still want to keep it separate, I'd like the name to be Serengeti_cheetah_fam_10.conf instead of cheetah_fam_10.conf, so it's
easy
to see what it is.
Myles
Myles,
I agree using the same serengeti_cheetah.conf is better so here is my attempt......
Marc
It works for me with the attached patch, which patches the fam10 Config.lb instead of the serengeti_cheetah/Config.lb for changing the payload.
If you add this, or something that is cleaner I'll test and ack it.
Myles
Ah! missed the LAB stuff, sorry. I will make those changes. Is the serengeti_cheetah_fam10-payload.patch really needed? It cleans up the config.lb a little but I don't see a functional difference.
You're right. It's only clean-up. That may be true for the Serengeti_cheetah-payload.patch as well.
Myles
Myles Watson wrote:
Myles Watson wrote:
On Dec 20, 2007 12:15 PM, Marc Jones Marc.Jones@amd.com wrote:
Ah! missed the LAB stuff, sorry. I will make those changes. Is the serengeti_cheetah_fam10-payload.patch really needed? It cleans up the config.lb a little but I don't see a functional difference.
You're right. It's only clean-up. That may be true for the Serengeti_cheetah-payload.patch as well.
Myles
OK, I removed added lab but not the payload patch for fam10.
Marc
Myles Watson wrote:
Myles Watson wrote:
On Dec 20, 2007 12:15 PM, Marc Jones Marc.Jones@amd.com wrote:
Ah! missed the LAB stuff, sorry. I will make those changes. Is the serengeti_cheetah_fam10-payload.patch really needed? It cleans
up
the config.lb a little but I don't see a functional difference.
You're right. It's only clean-up. That may be true for the Serengeti_cheetah-payload.patch as well.
Myles
OK, I removed added lab but not the payload patch for fam10.
Marc
Acked-by: Myles Watson myles@pel.cs.byu.edu
-
Jordan Crouse -
Marc Jones -
Myles Watson