Re: [coreboot] [v2] r4843 - trunk/coreboot-v2/src/cpu/intel/speedstep

[Uwe Hermann]

On Sat, Oct 24, 2009 at 08:36:52PM +0200, [e-mail] wrote:
> Some ACPI implementations don't like to see full paths within a scope for
> CPU power management, so don't add the scope name

Can you add a code comment there, explaining the issue, so that people
browsing the code will know about it?

Thanks, Uwe.

[v2] r4843 - trunk/coreboot-v2/src/cpu/intel/speedstep

[Patrick Georgi]

Am 25.10.2009 17:48, schrieb Uwe Hermann:
> On Sat, Oct 24, 2009 at 08:36:52PM +0200, [e-mail] wrote:
> > Some ACPI implementations don't like to see full paths within a scope for
> > CPU power management, so don't add the scope name
>
> Can you add a code comment there, explaining the issue, so that people
> browsing the code will know about it?

It's a simple error, that linux chose to look over.

The code essentially created (not sure if that's 100% valid acpi syntax, 
probably not, but you'll get the idea):

Scope(_PR_) {
    Name(_PR_.CPU0) { etc }
}

That nesting is wrong, it should be either

Scope(_PR_) {
    Name(CPU0) { etc }
}

or

Name(_PR_.CPU0) { etc }

Regards,
Patrick