v3 make distclean broken

[Carl-Daniel Hailfinger]

Hi,

I have a v3 tree (svn HEAD) which refuses to run "make clean" or "make
distclean". Steps to reproduce: Simply drop the attached .config in any
recent v3 tree, then try to run "make clean".

/sources/tmptrees/corebootv3-car_gas_bug_workaround> make distclean
Makefile:113: mainboard//Makefile: No such file or directory
make: *** No rule to make target `mainboard//Makefile'.  Stop.

Removing .config fixes it. I'd appreciate hints or fixes.

Regards,
Carl-Daniel

[Carl-Daniel Hailfinger]

On 09.08.2008 17:33, Carl-Daniel Hailfinger wrote:
> Hi,
>
> I have a v3 tree (svn HEAD) which refuses to run "make clean" or "make
> distclean". Steps to reproduce: Simply drop the attached .config in any
> recent v3 tree, then try to run "make clean".
>
> /sources/tmptrees/corebootv3-car_gas_bug_workaround> make distclean
> Makefile:113: mainboard//Makefile: No such file or directory
> make: *** No rule to make target `mainboard//Makefile'.  Stop.
>
> Removing .config fixes it. I'd appreciate hints or fixes.

The problem is that CONFIG_MAINBOARD_DIR is not set and that variable
must be present in the .config if the .config is present. Ouch.

Regards,
Carl-Daniel

[Peter Stuge]

On Sat, Aug 09, 2008 at 05:49:18PM +0200, Carl-Daniel Hailfinger wrote:
> > /sources/tmptrees/corebootv3-car_gas_bug_workaround> make distclean
> > Makefile:113: mainboard//Makefile: No such file or directory
> > make: *** No rule to make target `mainboard//Makefile'.  Stop.
> >
> > Removing .config fixes it. I'd appreciate hints or fixes.
>
> The problem is that CONFIG_MAINBOARD_DIR is not set and that variable
> must be present in the .config if the .config is present. Ouch.

I started getting this when you removed the mainboard Kconfigs.

//Peter

[Carl-Daniel Hailfinger]

On 09.08.2008 18:32, Peter Stuge wrote:
> On Sat, Aug 09, 2008 at 05:49:18PM +0200, Carl-Daniel Hailfinger wrote:
> > > /sources/tmptrees/corebootv3-car_gas_bug_workaround> make distclean
> > > Makefile:113: mainboard//Makefile: No such file or directory
> > > make: *** No rule to make target `mainboard//Makefile'.  Stop.
> > >
> > > Removing .config fixes it. I'd appreciate hints or fixes.
> >
> > The problem is that CONFIG_MAINBOARD_DIR is not set and that variable
> > must be present in the .config if the .config is present. Ouch.
>
> I started getting this when you removed the mainboard Kconfigs.

Thanks for the hint. However, the bug existed already before I removed
the mainboard Kconfigs. Simply try an older revision with a config that
doesn't have CONFIG_MAINBOARD_NAME.

Regards,
Carl-Daniel