Re: [coreboot] [v2] r4735 - in trunk/coreboot-v2/src/mainboard:amd/serengeti_cheetah intel/xe7501devkit msi/ms7135msi/ms9185 newisys/khepri sunw/ultra40 supermicro/h8dmetyan/s2881 tyan/s2891 tyan/s2892 tyan/s2895 via/epia-n

[Myles Watson]

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]]
> Author: uwe
> Date: 2009-10-07 18:29:12 +0200 (Wed, 07 Oct 2009)
> New Revision: 4735
> Convert all "default y" options to "select FOO" (shorter).

I think cosmetic cleanups like this ought to wait until all boards are
supported since Patrick is moving so quickly.  I think it would be easy to
break boards that are working.
> Also, drop per-board CONSOLE_VGA/PCI_ROM_RUN while I'm at it, they're
> global options in kconfig.

I agree.
> Signed-off-by: Uwe Hermann 
> Acked-by: Uwe Hermann

Thanks,
Myles

[v2] r4735 - in trunk/coreboot-v2/src/mainboard:amd/serengeti_cheetah intel/xe7501devkit msi/ms7135msi/ms9185 newisys/khepri sunw/ultra40 supermicro/h8dmetyan/s2881 tyan/s2891 tyan/s2892 tyan/s2895 via/epia-n

[Myles Watson]

> > Convert all "default y" options to "select FOO" (shorter).
>
> I think cosmetic cleanups like this ought to wait until all boards are
> supported since Patrick is moving so quickly.  I think it would be easy to
> break boards that are working.

I guess this could use a little more explanation.  Unless a CONFIG
variable is declared to be a bool in some other file, select does
nothing.  Maybe we should add a warning to Kconfig when we use a
select statement and there is no bool by that name.

Thanks,
Myles

Kconfig QA [was: [v2] r4735 - ...]

[Peter Stuge]

Myles Watson wrote:
> Unless a CONFIG variable is declared to be a bool in some other
> file, select does nothing.  Maybe we should add a warning to
> Kconfig when we use a select statement and there is no bool by that
> name.

This type of checking would be great! I would even suggest to have it
be part of the commit hook, so that any new issues are found quickly
after they have been introduced.

//Peter

[v2] r4735 - in trunk/coreboot-v2/src/mainboard:amd/serengeti_cheetah intel/xe7501devkit msi/ms7135msi/ms9185 newisys/khepri sunw/ultra40 supermicro/h8dmetyan/s2881 tyan/s2891 tyan/s2892 tyan/s2895 via/epia-n

[Uwe Hermann]

On Wed, Oct 07, 2009 at 11:09:46AM -0600, Myles Watson wrote:
> > > Convert all "default y" options to "select FOO" (shorter).
> >
> > I think cosmetic cleanups like this ought to wait until all boards are
> > supported since Patrick is moving so quickly.

Yep, I talked to Patrick on IRC beforehand, he said it wouldn't
interrupt his work/scripts.
> I guess this could use a little more explanation.  Unless a CONFIG
> variable is declared to be a bool in some other file, select does
> nothing.  Maybe we should add a warning to Kconfig when we use a
> select statement and there is no bool by that name.

Yep, we should document that somewhere (wiki probbaly,
http://www.coreboot.org/Kconfig).

Uwe.

Kconfig QA [was: [v2] r4735 - ..]

[Peter Stuge]

Uwe Hermann wrote:
> > Unless a CONFIG variable is declared to be a bool in some other
> > file, select does nothing.  Maybe we should add a warning to
> > Kconfig when we use a select statement and there is no bool by
> > that name.
>
> Yep, we should document that somewhere (wiki probbaly,
> http://www.coreboot.org/Kconfig).

Documentation is good, but best would be if tools catch this and give
a meaningful error message. That saves both time and frustration.

//Peter