[PATCH] Disable AC97 modem early on IP1000

[Joseph Smith]

This patch disables the AC97 modem via the ICH4 LPC disable function
register early in the boot process. Leaving it enabled was causing resource
allocation problems, making IO read/writes under 0x200 fail. As I found out
by trail and error it has to be done right after the LAN Enable gpio pin is
driven high.

Tested on hardware.
Signed-off-by: Joseph Smith

[Joseph Smith]

On Thu, 07 May 2009 02:01:18 -0400, Joseph Smith 
wrote:
> This patch disables the AC97 modem via the ICH4 LPC disable function
> register early in the boot process. Leaving it enabled was causing
> resource
> allocation problems, making IO read/writes under 0x200 fail. As I found
> out
> by trail and error it has to be done right after the LAN Enable gpio pin
> is
> driven high.
>
> Tested on hardware.
> Signed-off-by: Joseph Smith

oops patch attached...

[Myles Watson]

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]]
> On Behalf Of Joseph Smith
> Sent: Thursday, May 07, 2009 12:09 AM
> To: coreboot
> Subject: Re: [coreboot] [PATCH] Disable AC97 modem early on IP1000
>
> On Thu, 07 May 2009 02:01:18 -0400, Joseph Smith 
> wrote:
> > This patch disables the AC97 modem via the ICH4 LPC disable function
> > register early in the boot process. Leaving it enabled was causing
> > resource
> > allocation problems, making IO read/writes under 0x200 fail. As I found
> > out
> > by trail and error it has to be done right after the LAN Enable gpio pin
> > is
> > driven high.
> >
> > Tested on hardware.
> > Signed-off-by: Joseph Smith

Acked-by: Myles Watson

Thanks,
Myles

[Joseph Smith]

On Thu, 7 May 2009 15:55:11 -0600, "Myles Watson" 
wrote:
> > -----Original Message-----
> > From: [e-mail]
>
> [mailto:[e-mail]]
> > On Behalf Of Joseph Smith
> > Sent: Thursday, May 07, 2009 12:09 AM
> > To: coreboot
> > Subject: Re: [coreboot] [PATCH] Disable AC97 modem early on IP1000
> >
> > On Thu, 07 May 2009 02:01:18 -0400, Joseph Smith 
> > wrote:
> > > This patch disables the AC97 modem via the ICH4 LPC disable function
> > > register early in the boot process. Leaving it enabled was causing
> > > resource
> > > allocation problems, making IO read/writes under 0x200 fail. As I
>
> found
> > > out
> > > by trail and error it has to be done right after the LAN Enable gpio
>
> pin
> > > is
> > > driven high.
> > >
> > > Tested on hardware.
> > > Signed-off-by: Joseph Smith
>
> Acked-by: Myles Watson

Thanks Myles, r4258

[Joseph Smith]

On Thu, 07 May 2009 02:01:18 -0400, Joseph Smith 
wrote:
> This patch disables the AC97 modem via the ICH4 LPC disable function
> register early in the boot process. Leaving it enabled was causing
> resource
> allocation problems, making IO read/writes under 0x200 fail. As I found
> out
> by trail and error it has to be done right after the LAN Enable gpio pin
> is
> driven high.
>
> Tested on hardware.
> Signed-off-by: Joseph Smith

Can I get an ACK please?