Re: [coreboot] [PATCH] fix CONFIG_FS_PAYLOAD=1

[Marc Jones]

Jens Rottmann wrote:
> Fix compile errors if CONFIG_FS_PAYLOAD=1:
>
> Compile error in filo.c if AUTOBOOT_DELAY=0. Replace
> #ifndef AUTOBOOT_DELAY
> with
> #if !AUTOBOOT_DELAY
> which should work for both the #undef and the =0 case.
>
> In ext2fs.c, fat.c
> #if ARCH == 'i386'
> results in a compile warning: "multi-character character constant" and
> the condition ARCH == 'i386' is mis-evaluated as FALSE, eventually
> choking the assembler on a PPC instruction. Change it to
> #ifdef __i386
>
> Signed-off-by: Jens Rottmann

It looks like you are the firs/only x86 platform to use FS_PAYLOAD.
Acked-by: Marc Jones

And Stefan just beat me to the check in so I will stop now.....

:)

Marc