Re: [coreboot] [PATCH] various things to aid with CBFS on PPC, plus...

[Myles Watson]

> 20090819-2-trim-down-cbfs:

+static void tohex32(int val, char* dest)
+{
+	dest[0]=tohex8(val>>24);

Shouldn't val be unsigned?  You could also and this value with 0xff to
remove sign-extended bits.
> 20090819-3-more-noreturns-in-romcc:
> Mark two more functions in romcc as noreturn. Helps clang's scan-build a
> bit
>
> 20090819-4-cbfsify-ppc:
> Make PPC use CBFS. Support big endian ELF in cbfs-mkstage. Untested and
> not complete yet.
> 20090819-5-fix-ppc-build:
> The CBFS build system requires ROM_IMAGE_SIZE to have a somewhat
> plausible value.
>
> All of them are
> Signed-off-by: Patrick Georgi

Acked-by: Myles Watson