Uwe Hermann wrote:
I also cleaned up the Debug Port page in the wiki a bit.
Thanks for that! A link to #55 in Trac could be added, that's a libusb program to read the device, instead of the usb_debug module.
+++ src/southbridge/amd/sb600/sb600_enable_usbdebug.c (Arbeitskopie)
..
+/* Required for successful build, but currently empty. */ +void set_debug_port(unsigned int port) +{ +}
Maybe make that a weak function in common code instead? Is there actually any instance of the function which is not empty?
+++ src/mainboard/asrock/939a785gmh/romstage.c (Arbeitskopie)
..
+#if CONFIG_USBDEBUG +#include "southbridge/amd/sb700/sb700_enable_usbdebug.c" +#include "pc80/usbdebug_serial.c" +#endif
Can this go somewhere outside the mainboard directory?
If anything does need to go in the mainboard dir now, then would it be enough to add pc80/usbdebug_serial.c, and without #if? The #if could easily be moved into that file to save repetitive lines. And I'm thinking that maybe sb700_enable_usbdebug.c could be pulled in when both SOUTHBRIDGE_AMD_SB700 and CONFIG_USBDEBUG are selected?
sio_init(); w83627dhg_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); uart_init();
+#if CONFIG_USBDEBUG
- sb700_enable_usbdebug(0);
- early_usbdebug_init();
+#endif
- console_init();
Same question. Maybe the call to sb700_enable_usbdebug() can go into early_usbdebug_init() ?
+++ src/mainboard/gigabyte/ma78gm/romstage.c (Arbeitskopie)
..
@@ -139,6 +145,12 @@ it8718f_disable_reboot(); uart_init(); console_init();
+#if CONFIG_USBDEBUG
- sb700_enable_usbdebug(0);
- early_usbdebug_init();
+#endif
- printk(BIOS_DEBUG, "\n");
Here console_init() comes before early_usbdebug_init(), that's different from above. Does it matter?
//Peter