Stefan Reinauer (stefan.reinauer@coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/755
-gerrit
commit 8845fdb842f6a61d58ee63a987a02e4972f38111 Author: Stefan Reinauer reinauer@chromium.org Date: Thu Nov 17 13:03:38 2011 -0800
use movsl for copying resume memory back
It's not significantly faster, but easier to read and smaller.
Change-Id: Ibab0b478873912d67bf1f07743f628586353368a Signed-off-by: Stefan Reinauer reinauer@google.com --- src/arch/x86/boot/wakeup.S | 23 ++++++----------------- 1 files changed, 6 insertions(+), 17 deletions(-)
diff --git a/src/arch/x86/boot/wakeup.S b/src/arch/x86/boot/wakeup.S index a1df4d5..8ae337c 100644 --- a/src/arch/x86/boot/wakeup.S +++ b/src/arch/x86/boot/wakeup.S @@ -38,23 +38,12 @@ __wakeup: movw %ax, (__wakeup_segment)
/* Then overwrite coreboot with our backed up memory */ - movl 8(%esp), %esi - movl 12(%esp), %edi - movl 16(%esp), %ecx - shrl $4, %ecx -1: - movl 0(%esi),%eax - movl 4(%esi),%edx - movl 8(%esi),%ebx - movl 12(%esi),%ebp - addl $16,%esi - subl $1,%ecx - movl %eax,0(%edi) - movl %edx,4(%edi) - movl %ebx,8(%edi) - movl %ebp,12(%edi) - leal 16(%edi),%edi - jne 1b + cld + movl 8(%esp), %esi + movl 12(%esp), %edi + movl 16(%esp), %ecx + shrl $2, %ecx + rep movsl
/* Activate the right segment descriptor real mode. */ ljmp $0x28, $RELOCATED(1f)