Re: [LinuxBIOS] SPD Logical and Physical Banks

[Peter Stuge]

On Thu, May 17, 2007 at 03:48:45PM -0400, Corey Osgood wrote:
> > Nope, please use spd_read_byte() everywhere.
>
> spd_read_byte was removed to try an use a few less registers,

Rather use macros then, but both those functions should probably be
inline because they are so simple.
> > > for(i = 0; i < 4; i++)
> > > {
> > > spd_data = smbus_read_byte(ctrl->channel0[i], 126);
> > > if(spd_data == 0x66)
> > > {
> > > 	i = 6; //just to make sure
> >
> > Huh?
>
> To make sure the loop is broken, I wasn't sure if break (which
> should be the next line) would break out of the if statement or the
> for loop,

break exits for(), while() and switch() but not if().

//Peter