Re: [coreboot] flashrom: Remove dead M-Systems Disk on Chip code

[Stefan Reinauer]

Peter Stuge wrote:
> Patch attached.
>
> //Peter
>
> flashrom: Remove dead M-Systems Disk on Chip code
>
> DOC support has been disabled by default for many years. The write function
> does nothing but print text. It has a call to write_page_md2802() commented
> out, but that function does not exist. This is dead code with ugly #ifdefs.
>
> Updates README to reflect that there was a time when there was code, but it
> didn't work. Removes M-Systems #defines and also includes svn rm msys_doc.*
>
> Signed-off-by: Peter Stuge

Absolutely NACK.

The reason the code is not compiled in per default is that the probing
takes forever. Still, no reason to drop support.

I don't think we should drop features because we don't like a few ifdefs.