Dustin, please see my comment below?
Stefan, if my comment is fixed, is there any reason not to commit this code?
On Thursday, October 14, 2010 07:37:57 pm Dustin Harrison wrote: *snip comment and Kconfig*
===================================================================
--- mainboard/ep80579.c (revision 0) +++ mainboard/ep80579.c (revision 0) @@ -0,0 +1,103 @@ +/*
- SerialICE
- Copyright (C) 2009 coresystems GmbH (all other code)
- Copyright (C) 2008 Arastra, Inc. (i3100 functions)
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation; version 2 of the License.
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
- You should have received a copy of the GNU General Public License
- along with this program; if not, write to the Free Software
- Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
02110-1301 USA
- */
+/* This is a chipset init file for the Intel Truxton development kit
- which uses and EP80579 processor (Tolapai).
- This uses code directly copied from coreboot the coreboot project
- which is used to initialize the i3100 serial port which was oringally
- copyrighted by Arasta, Inc.
This comment is a little rough. Please fix it. Something like: This uses code directly copied from the coreboot project.
I don't think that you need to talk about the i3100 serial port code init copyright since Arasta, Inc., is properly listed in the copyright notice above.
*snip code*
I am going to take your word that the code works. Have you tested this on real hardware?
Thanks, wt