Re: [coreboot] [PATCH] v3: Kill dead code

[ron minnich]

Acked-by: Ronald G. Minnich

On Wed, Feb 13, 2008 at 3:03 PM, Carl-Daniel Hailfinger
 wrote:
> Kill dead code inside #if 0.
>
> The code was blindly copied from v2 in v3:r69. Was never enabled in v2
>  (committed as dead code by Eric Biederman in v2:r1664 with log message
>  "Updates for 64bit resource support, handling missing devices and cpus
>  in the config file").
>
> Signed-off-by: Carl-Daniel Hailfinger
> Index: LinuxBIOSv3-if0crud-next/device/pci_device.c
>
> --- LinuxBIOSv3-if0crud-next/device/pci_device.c        (Revision 596)
>  +++ LinuxBIOSv3-if0crud-next/device/pci_device.c        (Arbeitskopie)
>  @@ -247,19 +247,6 @@
>         if (resource->limit > limit) {
>                 resource->limit = limit;
>         }
>  -#if 0
>   if (resource->flags) {
>           printk(BIOS_DEBUG, "%s %02x ->",
>                  dev_path(dev), resource->index);
>           printk(BIOS_DEBUG,
>                  " value: 0x%08llx zeroes: 0x%08llx ones: 0x%08llx attr: %08lx\n",
>                  value, zeroes, ones, attr);
>           printk(BIOS_DEBUG,
>                  "%s %02x -> size: 0x%08llx max: 0x%08llx %s\n ",
>                  dev_path(dev), resource->index, resource->size,
>                  resource->limit, resource_type(resource));
>   }
>
> -#endif
>     return resource;
>
> }