Re: [coreboot] [PATCH] Hardcode PCI devices in Intel southbridge early init code

[Corey Osgood]

On Mon, Mar 31, 2008 at 5:00 PM,  wrote:
> Quoting Corey Osgood :
> > On Mon, Mar 31, 2008 at 4:37 PM, Corey Osgood 
> > wrote:
> > > On Mon, Mar 31, 2008 at 4:32 PM,  wrote:
> > > > Quoting Uwe Hermann :
> > > > > On Mon, Mar 31, 2008 at 04:04:59PM -0400,
> > >
> > > [e-mail]:
> > > > > > Ack that. The RM4100 has a i82801DB ICH4 and I am using the
>
> i82801xx
> > > > > > code. The original i82801DB code never worked right, so can we at
> > > > > > least drop that one?
> > > > >
> > > > > We should only drop code where all boards in svn have been migrated
>
> to
> > > > > i82801xx (and tested!) to be on the safe side. I.e. if there's an
> > > > > ICH* southbridge which is no longer used by any board, drop it (but
> > > >
> > > > only
> > > > > in that case). If this means we keep the old code around for the
>
> time
> > > > being,
> > > > > that's fine.
> > > > >
> > > > > But of course we should
> > > > > Make all _new_ boards work with i82801xx only (not the other
>
> ones)
> > > > > Only port the i82801xx to v3 (not the other ones)
> > > >
> > > > Like I said the i82801DB has never work and no ther boards use
>
> it.......
> > > > Ok, so how do we drop i82801DB via svn? Do we need ACK, Sign-off,
>
> etc?
> > > > Thanks - Joe
> > >
> > > Use "svn rm", and yes, you'd need an ack that I'd be happy to provide.
> > > Make sure you abuild test it, just to make sure that there's no board
>
> we've
> > > forgotten about that's using it. If there is, I'm 90% sure it's the one
>
> with
> > > the i855 northbridge, and that's never worked either, so probably all
>
> of it
> > > could be dropped.
> > >
> > > -Corey
> >
> > Yep, it's the digitallogic/adl855pc. I think it was Ron that said the
>
> 855
> > never worked, but that was a long time ago, and I can't be sure.
>
> Perhaps we
> > should just leave it kicking around, and focus on not letting this
>
> happen to
> > v3.
>
> Nope. The digitallogic/adl855pc uses the i82801DBM (ICH-4M). I am
> talking about the i82801DB (ICH4). Two different chipsets. There are
> no boards that use the i82801DB (ICH4). The code does NOT work.
>
> Removal of i82801DB (ICH4)
> Signed-off-by: Joseph Smith
>
> Thanks - Joe

The patch is missing, but when it gets here its
Acked-by: Corey Osgood